Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved OSCALLoader to components #94

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Moved OSCALLoader to components #94

merged 1 commit into from
Jul 2, 2021

Conversation

rgauss
Copy link
Contributor

@rgauss rgauss commented Jul 2, 2021

Also separated Loader form into its own OSCALLoaderForm component

@rgauss rgauss requested a review from Bronstrom July 2, 2021 20:33
Bronstrom
Bronstrom approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@Bronstrom Bronstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests and Viewer all check out. Changes look good to me!

@Bronstrom Bronstrom merged commit 20065f8 into EGRC-168 Jul 2, 2021
@rgauss rgauss deleted the EGRC-168-rgauss branch July 7, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bronstrom Bronstrom Bronstrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rgauss @Bronstrom