Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change global containers name usage #270

Merged
merged 9 commits into from Dec 26, 2018
Merged

Change global containers name usage #270

merged 9 commits into from Dec 26, 2018

Conversation

sagarnasit
Copy link
Contributor

@sagarnasit sagarnasit self-assigned this Dec 21, 2018
@sagarnasit sagarnasit mentioned this pull request Dec 21, 2018
Merged
mrrobot47
mrrobot47 previously approved these changes Dec 24, 2018
View reviewed changes
Copy link
Member

@mrrobot47 mrrobot47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrrobot47 mrrobot47 dismissed their stale review December 24, 2018 04:35

Accidental approval

mrrobot47
mrrobot47 requested changes Dec 24, 2018
View reviewed changes
Copy link
Member

@mrrobot47 mrrobot47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update usage here:

site-command/templates/docker-compose.mustache

Line 41 in ff98dc3

- ee-global-nginx-proxy:${VIRTUAL_HOST}

@mrrobot47 mrrobot47 added this to In progress in v4 Maintenance Releases via automation Dec 24, 2018
@mrrobot47 mrrobot47 merged commit 164b345 into EasyEngine:develop Dec 26, 2018
v4 Maintenance Releases automation moved this from In progress to Done Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrrobot47 mrrobot47 mrrobot47 requested changes

Assignees

@sagarnasit sagarnasit

Labels
None yet
Projects
v4 Maintenance Releases
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sagarnasit @mrrobot47