Add subdom and subdir tests #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirtangajjar
force-pushed
the
add_more_tests
branch
from
469da23
to
f14e15a
Compare
Signed-off-by: Kirtan Gajjar <kirtangajjar95@gmail.com>
Signed-off-by: Kirtan Gajjar <kirtangajjar95@gmail.com>
kirtangajjar
force-pushed
the
add_more_tests
branch
from
9116618
to
39a079d
Compare
mrrobot47
reviewed
Jul 16, 2018
| */ | ||
| public function theSiteShouldBeMultisite( $site, $type ) | ||
| { | ||
| $php_container = implode( explode( '.', $site ) ) . '_php_1'; |
There was a problem hiding this comment.
Instead of evaluating the name of the container and doing docker exec, changing directory to the site root and then doing docker-compose exec could be better and less error-prone.
There was a problem hiding this comment.
Yup. Good idea!
mrrobot47
requested changes
Jul 16, 2018
| { | ||
| $this->commands = []; | ||
| } | ||
|
|
||
| /** | ||
| * @AfterFeature | ||
| */ |
There was a problem hiding this comment.
Add the sites of this feature in cleanup.
wp.test
wpsubdir.test
wpsubdom.test
need to be added in cleanup on completion.
There was a problem hiding this comment.
Yes. Didn't add it before as updated cleanup function was in another PR(which was yet to be merged)
kirtangajjar
force-pushed
the
add_more_tests
branch
3 times, most recently
from
fdf8abc
to
de01976
Compare
kirtangajjar
force-pushed
the
add_more_tests
branch
from
de01976
to
da66cb0
Compare
Signed-off-by: Kirtan Gajjar <kirtangajjar95@gmail.com>
mrrobot47
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kirtan Gajjar kirtangajjar95@gmail.com