Allow to configure ssl in vanilla connection string #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pliner
commented
May 12, 2023
| [Fact] | ||
| public void Should_parse_global_timeout() | ||
| { | ||
| const string connectionStringWithTimeout = "host=localhost;timeout=13"; |
There was a problem hiding this comment.
Timeout is covered by the previous test
Pliner
changed the title
Pliner
commented
May 13, 2023
| if (!propertyInfo.CanWrite) | ||
| throw new ArgumentOutOfRangeException(nameof(getter), "Member is not a writeable property"); | ||
|
|
||
| var valueParameterExpr = Expression.Parameter(typeof(TProperty), "value"); |
There was a problem hiding this comment.
To support expressions with a single member access(c => c.Name) as well as with multiple ones(c => c.Ssl.Enabled).
Pliner
added a commit
that referenced
this pull request
May 14, 2023
* Allow to enable ssl in vanilla connection string * Remove irrelevant comments * Support other ssl options * Ssl server name should be taken from the hostname * Stop setting a default version * Defensively copy Ssl, set hostname to servername * Remain only ssl flag * Remove useless comments * Do not copy endpoint ssl * Simplify code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1671, supports only
ssl=trueparameter.There is no need to patch hosts because of that: