Enable ca 1852 rule

.editorconfig

@@ -197,3 +197,7 @@ csharp_preserve_single_line_statements = false
 
 # C# formatting settings - Namespace options
 csharp_style_namespace_declarations = file_scoped:warning
+
+[*.{cs,vb}]
+# Sealed classes https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1852
+dotnet_diagnostic.CA1852.severity = warning

Source/EasyNetQ.DI.Tests/ContainerAdaptersData.cs

@@ -12,7 +12,7 @@
 
 namespace EasyNetQ.DI.Tests;
 
-internal class ContainerAdaptersData : IEnumerable<object[]>
+internal sealed class ContainerAdaptersData : IEnumerable<object[]>
 {
     public IEnumerator<object[]> GetEnumerator()
     {

Source/EasyNetQ.DI.Tests/MicrosoftDependencyScopeTests.cs

@@ -36,7 +36,7 @@ private interface IService : IDisposable
         bool Disposed { get; set; }
     }
 
-    private class Service : IService
+    private sealed class Service : IService
     {
         public bool Disposed { get; set; }
 

Source/EasyNetQ.Hosepipe.Tests/ProgramIntegrationTests.cs

@@ -76,7 +76,7 @@ public void ConsumeMessages()
         bus.Dispose();
     }
 
-    private class TestMessage
+    private sealed class TestMessage
     {
         public string Text { get; set; }
     }

Source/EasyNetQ.Hosepipe.Tests/QueueRetrievalTests.cs

@@ -55,7 +55,7 @@ public void ConsumeMessages()
         bus.Dispose();
     }
 
-    private class TestMessage
+    private sealed class TestMessage
     {
         public string Text { get; set; }
     }

Source/EasyNetQ.Serialization.NewtonsoftJson/NewtonsoftJsonSerializer.cs

@@ -60,7 +60,7 @@ public object BytesToMessage(Type messageType, in ReadOnlyMemory<byte> bytes)
         return jsonSerializer.Deserialize(reader, messageType)!;
     }
 
-    private class JsonSerializerArrayPool<T> : Newtonsoft.Json.IArrayPool<T>
+    private sealed class JsonSerializerArrayPool<T> : Newtonsoft.Json.IArrayPool<T>
     {
         public static JsonSerializerArrayPool<T> Instance { get; } = new();
 

Source/EasyNetQ.Serialization.Tests/SerializerTests.cs

@@ -141,16 +141,16 @@ private class A
     {
     }
 
-    private class B : A
+    private sealed class B : A
     {
     }
 
-    private class PolyMessage
+    private sealed class PolyMessage
     {
         public A AorB { get; set; }
     }
 
-    private class Message
+    private sealed class Message
     {
         public string Text { get; set; }
     }

Source/EasyNetQ.Tests/AutoSubscriberTests/When_auto_subscribing.cs

@@ -72,7 +72,7 @@ public void Should_have_started_consuming_from_the_correct_queues()
     }
 
     // Discovered by reflection over test assembly, do not remove.
-    private class MyConsumer : IConsume<MessageA>, IConsume<MessageB>, IConsume<MessageC>
+    private sealed class MyConsumer : IConsume<MessageA>, IConsume<MessageB>, IConsume<MessageC>
     {
         public void Consume(MessageA message, CancellationToken cancellationToken)
         {
@@ -99,15 +99,15 @@ public virtual void Consume(TMessage message, CancellationToken cancellationToke
         }
     }
 
-    private class MessageA
+    private sealed class MessageA
     {
     }
 
-    private class MessageB
+    private sealed class MessageB
     {
     }
 
-    private class MessageC
+    private sealed class MessageC
     {
     }
 }

Source/EasyNetQ.Tests/AutoSubscriberTests/When_auto_subscribing_async.cs

@@ -71,7 +71,7 @@ public void Should_have_started_consuming_from_the_correct_queues()
     }
 
     //Discovered by reflection over test assembly, do not remove.
-    private class MyAsyncConsumer : IConsumeAsync<MessageA>, IConsumeAsync<MessageB>, IConsumeAsync<MessageC>
+    private sealed class MyAsyncConsumer : IConsumeAsync<MessageA>, IConsumeAsync<MessageB>, IConsumeAsync<MessageC>
     {
         public Task ConsumeAsync(MessageA message, CancellationToken cancellationToken)
         {
@@ -91,15 +91,15 @@ public Task ConsumeAsync(MessageC message, CancellationToken cancellationToken)
         }
     }
 
-    private class MessageA
+    private sealed class MessageA
     {
     }
 
-    private class MessageB
+    private sealed class MessageB
     {
     }
 
-    private class MessageC
+    private sealed class MessageC
     {
     }
 }

Source/EasyNetQ.Tests/AutoSubscriberTests/When_auto_subscribing_async_with_subscription_configuration.cs

@@ -52,7 +52,7 @@ public void Should_have_called_subscribe_with_action_capable_of_configuring_subs
     }
 
     // Discovered by reflection over test assembly, do not remove.
-    private class MyConsumerWithAttr : IConsumeAsync<MessageA>
+    private sealed class MyConsumerWithAttr : IConsumeAsync<MessageA>
     {
         [AutoSubscriberConsumer(SubscriptionId = "MyAttrTest")]
         [SubscriptionConfiguration(AutoDelete = true, Expires = 10, PrefetchCount = 10, Priority = 10)]
@@ -62,7 +62,7 @@ public Task ConsumeAsync(MessageA message, CancellationToken cancellationToken)
         }
     }
 
-    private class MessageA
+    private sealed class MessageA
     {
     }
 }
@@ -117,7 +117,7 @@ public void Should_have_called_subscribe_with_action_capable_of_configuring_subs
     }
 
     // Discovered by reflection over test assembly, do not remove.
-    private class MyConsumerWithAttr : IConsumeAsync<MessageA>
+    private sealed class MyConsumerWithAttr : IConsumeAsync<MessageA>
     {
         [AutoSubscriberConsumer(SubscriptionId = "MyAttrTest")]
         [SubscriptionConfiguration(AutoDelete = true, Expires = 10, PrefetchCount = 10, Priority = 10)]
@@ -127,7 +127,7 @@ Task IConsumeAsync<MessageA>.ConsumeAsync(MessageA message, CancellationToken ca
         }
     }
 
-    private class MessageA
+    private sealed class MessageA
     {
     }
 }

Source/EasyNetQ.Tests/AutoSubscriberTests/When_auto_subscribing_async_with_subscription_configuration_action.cs

@@ -61,7 +61,7 @@ public void Should_have_called_subscribe_with_action_capable_of_configuring_subs
 
     // Discovered by reflection over test assembly, do not remove.
     // ReSharper disable once UnusedMember.Local
-    private class MyConsumerWithAction : IConsumeAsync<MessageA>
+    private sealed class MyConsumerWithAction : IConsumeAsync<MessageA>
     {
         [AutoSubscriberConsumer(SubscriptionId = "MyActionTest")]
         public Task ConsumeAsync(MessageA message, CancellationToken cancellationToken)
@@ -70,7 +70,7 @@ public Task ConsumeAsync(MessageA message, CancellationToken cancellationToken)
         }
     }
 
-    private class MessageA
+    private sealed class MessageA
     {
     }
 }

Source/EasyNetQ.Tests/AutoSubscriberTests/When_auto_subscribing_async_with_subscription_configuration_action_and_attribute.cs

@@ -61,7 +61,7 @@ public void Should_have_called_subscribe_async_with_attribute_values_notaction_v
 
     // Discovered by reflection over test assembly, do not remove.
     // ReSharper disable once UnusedMember.Local
-    private class MyConsumerWithActionAndAttribute : IConsumeAsync<MessageA>
+    private sealed class MyConsumerWithActionAndAttribute : IConsumeAsync<MessageA>
     {
         [AutoSubscriberConsumer(SubscriptionId = "MyActionAndAttributeTest")]
         [SubscriptionConfiguration(AutoDelete = true, Expires = 10, PrefetchCount = 10, Priority = 10)]
@@ -71,7 +71,7 @@ public Task ConsumeAsync(MessageA message, CancellationToken cancellationToken)
         }
     }
 
-    private class MessageA
+    private sealed class MessageA
     {
     }
 }

Source/EasyNetQ.Tests/AutoSubscriberTests/When_auto_subscribing_with_explicit_implementation.cs

@@ -71,7 +71,7 @@ public void Should_have_started_consuming_from_the_correct_queues()
     }
 
     // Discovered by reflection over test assembly, do not remove.
-    private class MyConsumer : IConsume<MessageA>, IConsume<MessageB>, IConsume<MessageC>
+    private sealed class MyConsumer : IConsume<MessageA>, IConsume<MessageB>, IConsume<MessageC>
     {
         void IConsume<MessageA>.Consume(MessageA message, CancellationToken cancellationToken)
         {
@@ -98,17 +98,17 @@ public virtual void Consume(TMessage message, CancellationToken cancellationToke
         }
     }
 
-    private class MessageA
+    private sealed class MessageA
     {
         public string Text { get; set; }
     }
 
-    private class MessageB
+    private sealed class MessageB
     {
         public string Text { get; set; }
     }
 
-    private class MessageC
+    private sealed class MessageC
     {
         public string Text { get; set; }
     }

Source/EasyNetQ.Tests/AutoSubscriberTests/When_auto_subscribing_with_subscription_configuration.cs

@@ -51,7 +51,7 @@ public void Should_have_called_subscribe_with_action_capable_of_configuring_subs
     }
 
     // Discovered by reflection over test assembly, do not remove.
-    private class MyConsumerWithAttr : IConsume<MessageA>
+    private sealed class MyConsumerWithAttr : IConsume<MessageA>
     {
         [AutoSubscriberConsumer(SubscriptionId = "MyAttrTest")]
         [SubscriptionConfiguration(AutoDelete = true, Expires = 10, PrefetchCount = 10, Priority = 10)]
@@ -60,7 +60,7 @@ public void Consume(MessageA message, CancellationToken cancellationToken)
         }
     }
 
-    private class MessageA
+    private sealed class MessageA
     {
     }
 }

Source/EasyNetQ.Tests/AutoSubscriberTests/When_auto_subscribing_with_subscription_configuration_action.cs

@@ -58,15 +58,15 @@ public void Should_have_called_subscribe_with_action_capable_of_configuring_subs
     }
 
     // Discovered by reflection over test assembly, do not remove.
-    private class MyConsumerWithAction : IConsume<MessageA>
+    private sealed class MyConsumerWithAction : IConsume<MessageA>
     {
         [AutoSubscriberConsumer(SubscriptionId = "MyActionTest")]
         public void Consume(MessageA message, CancellationToken cancellationToken)
         {
         }
     }
 
-    private class MessageA
+    private sealed class MessageA
     {
     }
 }

Source/EasyNetQ.Tests/AutoSubscriberTests/When_auto_subscribing_with_subscription_configuration_action_and_attribute.cs

@@ -58,7 +58,7 @@ public void Should_have_called_subscribe_with_attribute_values_notaction_values(
     }
 
     // Discovered by reflection over test assembly, do not remove.
-    private class MyConsumerWithActionAndAttribute : IConsume<MessageA>
+    private sealed class MyConsumerWithActionAndAttribute : IConsume<MessageA>
     {
         [AutoSubscriberConsumer(SubscriptionId = "MyActionAndAttributeTest")]
         [SubscriptionConfiguration(AutoDelete = true, Expires = 10, PrefetchCount = 10, Priority = 10)]
@@ -67,7 +67,7 @@ public void Consume(MessageA message, CancellationToken cancellationToken)
         }
     }
 
-    private class MessageA
+    private sealed class MessageA
     {
     }
 }

Source/EasyNetQ.Tests/AutoSubscriberTests/When_auto_subscribing_with_subscription_configuration_attribute_no_expires.cs

@@ -51,7 +51,7 @@ public void Should_have_called_subscribe_with_no_expires()
     }
 
     // Discovered by reflection over test assembly, do not remove.
-    private class MyConsumerWithAttr : IConsume<MessageA>
+    private sealed class MyConsumerWithAttr : IConsume<MessageA>
     {
         [AutoSubscriberConsumer(SubscriptionId = "MyAttrTest")]
         [SubscriptionConfiguration(AutoDelete = true, PrefetchCount = 10, Priority = 10)]
@@ -60,7 +60,7 @@ public void Consume(MessageA message, CancellationToken cancellationToken)
         }
     }
 
-    private class MessageA
+    private sealed class MessageA
     {
     }
 }

Source/EasyNetQ.Tests/ChannelDispatcherTests/When_an_action_is_invoked_that_throws_using_multi_channel.cs

@@ -49,7 +49,7 @@ public async Task Should_call_action_when_previous_threw_an_exception()
         result.Should().Be(42);
     }
 
-    private class CrazyTestOnlyException : Exception
+    private sealed class CrazyTestOnlyException : Exception
     {
     }
 }

Source/EasyNetQ.Tests/ChannelDispatcherTests/When_an_action_is_invoked_that_throws_using_single_channel.cs

@@ -49,7 +49,7 @@ public async Task Should_call_action_when_previous_threw_an_exception()
         result.Should().Be(42);
     }
 
-    private class CrazyTestOnlyException : Exception
+    private sealed class CrazyTestOnlyException : Exception
     {
     }
 }

Source/EasyNetQ.Tests/ConsumeTests/When_a_responder_is_cancelled.cs

@@ -60,7 +60,7 @@ private Task DeliverMessageAsync(RpcRequest request)
         );
     }
 
-    private record RpcRequest;
+    private sealed record RpcRequest;
 
-    private record RpcResponse;
+    private sealed record RpcResponse;
 }

Source/EasyNetQ.Tests/DefaultMessageConsumerTests.cs

@@ -18,7 +18,7 @@ public void Should_create_consumer_instance_and_consume_message()
     }
 
     // Discovered by reflection over test assembly, do not remove.
-    private class MyMessageConsumer : IConsume<MyMessage>
+    private sealed class MyMessageConsumer : IConsume<MyMessage>
     {
         public static Action<MyMessage> ConsumedMessageFunc { get; set; }
 

Source/EasyNetQ.Tests/StubCorrelationIdGenerator.cs

@@ -1,6 +1,6 @@
 namespace EasyNetQ.Tests;
 
-internal class StaticCorrelationIdGenerationStrategy : ICorrelationIdGenerationStrategy
+internal sealed class StaticCorrelationIdGenerationStrategy : ICorrelationIdGenerationStrategy
 {
     private readonly string correlationId;