Skip to content

Commit

Permalink
[chore] Add missing parameters options (#470)
Browse files Browse the repository at this point in the history
- Add `Service` parameter when creating an order
- Add `PredefinedPackage` parameter when creating a parcel
- Move CarrierMetadataServiceTest to proper folder (uses parameter sets)
  • Loading branch information
nwithan8 committed May 11, 2023
1 parent 44a344e commit 1ffd795
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
using Xunit;
using CustomAssertions = EasyPost.Tests._Utilities.Assertions.Assert;

namespace EasyPost.Tests.ServicesTests.Beta
namespace EasyPost.Tests.ServicesTests.WithParameters.Beta
{
public class CarrierMetadataServiceTests : UnitTest
{
public CarrierMetadataServiceTests() : base("beta_carrier_metadata")
public CarrierMetadataServiceTests() : base("beta_carrier_metadata_with_parameters")
{
}

Expand Down
6 changes: 6 additions & 0 deletions EasyPost/Parameters/Order/Create.cs
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ public class Create : BaseParameters, IOrderParameter
[TopLevelRequestParameter(Necessity.Optional, "order", "to_address")]
public IAddressParameter? ToAddress { get; set; }

/// <summary>
/// One-call-buy an <see cref="Models.API.Order"/> by specifying a service.
/// </summary>
[TopLevelRequestParameter(Necessity.Optional, "order", "service")]
public string? Service { get; set; }

#endregion
}
}
8 changes: 8 additions & 0 deletions EasyPost/Parameters/Parcel/Create.cs
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ public class Create : BaseParameters, IParcelParameter
[NestedRequestParameter(typeof(Beta.Rate.Retrieve), Necessity.Optional, "width")]
public double? Width { get; set; }

/// <summary>
/// Predefined package type to use for the <see cref="Models.API.Parcel"/>.
/// </summary>
[TopLevelRequestParameter(Necessity.Optional, "parcel", "predefined_package")]
[NestedRequestParameter(typeof(Shipment.Create), Necessity.Optional, "predefined_package")]
[NestedRequestParameter(typeof(Beta.Rate.Retrieve), Necessity.Optional, "predefined_package")]
public string? PredefinedPackage { get; set; }

#endregion
}
}

0 comments on commit 1ffd795

Please sign in to comment.