Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Add BuyerAddress and ReturnAddress support in EasyPost.Parameters.Order.Create #560

Closed
1 task done
cary-opcenter opened this issue Apr 24, 2024 · 5 comments · Fixed by #561
Closed
1 task done
Labels
triage Issue is being researched

Comments

@cary-opcenter
Copy link

Feature Request Is New

  • I have verified that the requested feature does not already exist or has not already been requested.

Description of the feature

The buyer_address and return_address objects are part of the order object, but cannot currently be added to order parameters using the csharp client library.

I can include the BuyerAddress and ReturnAddress to a shipment parameter, but my tests show that these addresses are replaced or overridden by the ToAddress and FromAddress which is the default behavior when not provided in the order object.

While I am a novice programmer, I've attempted several ways to pass these address objects into an order parameter, but have had no luck. I've attached a screenshot of how I would like to implement a BuyerAddress when building an order, but the compiler has an error: "CS0117: 'Create' does not contain a definition for 'BuyerAddress'".
image

As an aside to this feature request, if there is another method to send these address objects with my order object I could use some advice or suggestions. (Thanks in advance) I would be glad to contribute to this issue however I could, let me know what I can do to assist.

@cary-opcenter cary-opcenter added the triage Issue is being researched label Apr 24, 2024
@HottieHotton
Copy link

Hey @cary-opcenter, this is Braxton Hotton from Support who helped you a few days ago. I had another person ask about this and this is something that our engineers will add along with IsReturn being an allowed parameter in the top level of Orders. I just got confirmation not to long ago that this will be happening.

Our engineering team will be in touch shortly!

Best,
Braxton Hotton
Technical Support Engineer
easypost.com


The Simple Shipping Solution

@nwithan8 nwithan8 linked a pull request Apr 24, 2024 that will close this issue
4 tasks
@nwithan8
Copy link
Member

nwithan8 commented Apr 24, 2024

Hello @cary-opcenter , thanks for reaching out. As Braxton said, BuyerAddress is something we'd have to explicitly add support for in the parameter sets, and unfortunately something that got overlooked. It's in progress in #561 and should be available in the next release.

@cary-opcenter
Copy link
Author

Hi @HottieHotton and @nwithan8 Thanks for the quick response! It's very cool to hear that these updates were already in the pipeline, and I am looking forward to the update.

I appreciate the great service you guys provide and the excellent work done by the EasyPost team 🙌

@HottieHotton
Copy link

HottieHotton commented Apr 24, 2024

Hey @cary-opcenter, of course! Glad we've been able to assist! I just wanted to follow up that the code is in review now. We've decided NOT to move forward with IsReturn being added to the Order level, as those should be done via the /shipment endpoint. However, BuyerAddress and ReturnAddress will be added once this release is out.

Please let us know if you have any further questions!

Best,
Braxton Hotton
Technical Support Engineer
easypost.com


The Simple Shipping Solution

@nwithan8
Copy link
Member

nwithan8 commented May 1, 2024

@cary-opcenter v6.4.0 has just been released and includes the missing parameters that Braxton mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issue is being researched
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants