Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Add missing parameters for creating orders #561

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented Apr 24, 2024

Description

  • Add missing BuyerAddress and ReturnAddress parameters for Order.Create parameter set

Testing

  • N/A

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get some tests for these or some e2e tests? Orders are kind of tricky where most of these details will typically be on each shipment and not on the parent order (addresses aside). I'd like to avoid adding params that aren't valid at the parent level by testing first.

@nwithan8 nwithan8 marked this pull request as draft April 24, 2024 16:52
@nwithan8
Copy link
Member Author

In draft while discussed internally.

@nwithan8
Copy link
Member Author

Can we get some tests for these or some e2e tests? Orders are kind of tricky where most of these details will typically be on each shipment and not on the parent order (addresses aside). I'd like to avoid adding params that aren't valid at the parent level by testing first.

We have confirmed internally that these parameters are accepted in certain multi-parcel scenarios. It's not guaranteed that they will always be respected versus ignored, but it's important that we make them available for end-users to use as needed.

@nwithan8 nwithan8 marked this pull request as ready for review April 24, 2024 17:40
Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel better with just exposing return/buyer addresses

@nwithan8 nwithan8 merged commit f9cbfbc into master Apr 24, 2024
14 checks passed
@nwithan8 nwithan8 deleted the order_parameters branch April 24, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Add BuyerAddress and ReturnAddress support in EasyPost.Parameters.Order.Create
4 participants