Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add carrier metadata endpoint (beta) #431

Merged
merged 4 commits into from
Apr 18, 2023
Merged

feat: Add carrier metadata endpoint (beta) #431

merged 4 commits into from
Apr 18, 2023

Conversation

nwithan8
Copy link
Member

Description

  • Add new carrier metadata endpoint (beta) to beta client
  • Add custom assertion tools (.Any surprisingly missing from Xunit)

Testing

  • Add unit tests, cassettes for carrier metadata

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

- Add unit tests, cassettes for carrier metadata
- Add custom assertion tools (.Any surprisingly missing from Xunit)
@nwithan8 nwithan8 requested a review from a team as a code owner April 18, 2023 04:40
@nwithan8
Copy link
Member Author

The custom assertion toolset might be a bit overzealous. I was just surprised that Xunit has a .All assertion, but not a .Any (or .Some, etc.). Rather than dealing with a boolean in a one-off unit test, I figured making a proper assertion function for it might help for reusability later on.

Just tell me to remove it like I fully anticipate happening 😄

Copy link
Member

@jchen293 jchen293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a changelog when releasing it later today

@Justintime50 Justintime50 merged commit 8f4563b into master Apr 18, 2023
@Justintime50 Justintime50 deleted the metadata branch April 18, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants