Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Models are immutable #458

Closed
wants to merge 1 commit into from
Closed

[chore] Models are immutable #458

wants to merge 1 commit into from

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented May 4, 2023

Description

  • All setters for model properties are internal (end-user cannot modify any property of an object outside of an Update API call)

Testing

  • No changes to unit tests
    • Test suite has internal access to source code, allowing it to use internal setters as needed during testing. End-users importing this library will not have internal access, and therefore won't be able to access the setters.

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

…fy any property of an object outside of an Update API call)
@nwithan8 nwithan8 requested a review from a team as a code owner May 4, 2023 17:48
@nwithan8
Copy link
Member Author

nwithan8 commented May 4, 2023

Decided against this approach.

@nwithan8 nwithan8 closed this May 4, 2023
@nwithan8 nwithan8 deleted the readonly branch May 9, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant