Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix "All" parameter sets #545

Merged
merged 3 commits into from
Feb 7, 2024
Merged

[chore] Fix "All" parameter sets #545

merged 3 commits into from
Feb 7, 2024

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented Feb 7, 2024

Description

  • Add missing "sort" parameter for batch list parameter set (enum)
  • Mark unused parameters for various list endpoints as "obsolete"
  • Handle de/serializing enums in parameter sets

Testing

  • All unit tests pass
  • Batch "all" test updated to include "sort" parameter to confirm enum de/serialization works as expected
    • Re-record cassette due to parameters changing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

- Mark unused parameters for various list endpoints as "obsolete"
- Handle de/serializing enums in parameter sets
@nwithan8 nwithan8 requested a review from a team as a code owner February 7, 2024 08:17
Copy link
Member

@jchen293 jchen293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, please have another review from @Justintime50 before merging to master

@nwithan8 nwithan8 merged commit cb26fe6 into master Feb 7, 2024
14 checks passed
@nwithan8 nwithan8 deleted the list_parameters branch February 7, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants