Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix carrier account parameter serialization for stateless rates #550

Conversation

nwithan8
Copy link
Member

Description

Fix how the carrier_accounts parameter for stateless rates retrieval payload is serialized. Maintains existing CarrierAccount parameter, but adjusts behind-the-scenes for required schema immediately pre-flight.

Closes #549

Testing

  • Update, sync related unit tests
  • Re-record relevant cassettes

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

- Update, sync related unit tests
- Re-record relevant cassettes
@Justintime50
Copy link
Member

Could use a changelog entry too

@nwithan8 nwithan8 merged commit c301d04 into master Mar 18, 2024
14 checks passed
@nwithan8 nwithan8 deleted the 549-bug-retrievestatelessrates-does-not-send-carrieraccounts-correctly branch March 18, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: RetrieveStatelessRates does not send CarrierAccounts correctly
3 participants