Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Add missing parameters for customs item #568

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented Jun 5, 2024

Description

Add missing optional parameters (e.g. "code", "manufacturer", "eccn") to customs item parameter set.

Closes #567

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team as a code owner June 5, 2024 17:14
Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds it to the parameters, but can they pass this via the older dict approach too?

@nwithan8
Copy link
Member Author

nwithan8 commented Jun 5, 2024

This adds it to the parameters, but can they pass this via the older dict approach too?

Yes, anyone can pass any parameters via the legacy dictionary method.

@nwithan8 nwithan8 merged commit c1682f6 into master Jun 5, 2024
14 checks passed
@nwithan8 nwithan8 deleted the customs_item_code branch June 5, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Code is not accessible in CustomsItem object
3 participants