Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Missing inheritance preventing Batch object use in parameter sets #570

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

nwithan8
Copy link
Member

Description

  • Fix Batch class not inheriting IBatchParameter, preventing a Batch object from being used in a parameter set. Ex:
Batch batch = await client.Batch.Retrieve("batch_123");
EasyPost.Parameters.Pickup.Create parameters = new()
{
    Batch = batch, // compile error due to mismatch type
    Instructions = "Special pickup instructions",
};
  • Prep for v6.5.1 release

Testing

  • Test snippet above now compiles

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team as a code owner June 10, 2024 22:57
@nwithan8 nwithan8 merged commit 0798d36 into master Jun 10, 2024
14 checks passed
@nwithan8 nwithan8 deleted the batch_parameter_inheritance branch June 10, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants