Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Remove "required" validation for Shipment parameter of Pickup.Create set #572

Merged
merged 1 commit into from
Jun 12, 2024
Merged

[fix] Remove "required" validation for Shipment parameter of Pickup.Create set #572

merged 1 commit into from
Jun 12, 2024

Conversation

nwithan8
Copy link
Member

Description

Either Shipment or Batch can be used when creating a Pickup, meaning the Shipment parameter should be optional, not required.

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team as a code owner June 12, 2024 19:40
@nwithan8 nwithan8 merged commit e5b2f3a into master Jun 12, 2024
14 checks passed
@nwithan8 nwithan8 deleted the pickup_parameters branch June 12, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen293 jchen293 jchen293 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nwithan8 @jchen293