Skip to content

Commit

Permalink
[chore] Add Node 22 check to CI (#450)
Browse files Browse the repository at this point in the history
* - Add Node 22 check to CI
* - Ignore transitive vulnerability
  • Loading branch information
nwithan8 committed Jun 12, 2024
1 parent 942afda commit 0ad903e
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 7 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x, 14.x, 16.x, 18.x, 20.x]
node-version: [12.x, 13.x, 14.x, 15.x, 16.x, 17.x, 18.x, 19.x, 20.x, 21.x, 22.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand All @@ -29,7 +29,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 20
node-version: 22
- run: make install
- run: make install-styleguide
- run: make build
Expand All @@ -41,7 +41,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 20
node-version: 22
- run: make install
- run: make install-styleguide
- run: make build
Expand All @@ -60,7 +60,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 20
node-version: 22
- name: Install Dependencies
run: make install
- name: Generate Docs
Expand Down
19 changes: 16 additions & 3 deletions audit-ci.jsonc
Original file line number Diff line number Diff line change
@@ -1,12 +1,25 @@
{
"$schema": "https://github.com/IBM/audit-ci/raw/main/docs/schema.json",
"critical": true, // Only fail the audit if there are critical vulnerabilities.
"critical": true,
// Only fail the audit if there are critical vulnerabilities.
"allowlist": [
{
"GHSA-8cp3-66vr-3r4c": {
"active": true,
"expiry": "2024-10-22", // Re-evaluate this vulnerability after this date.
"notes": "Transitive dependency of `superagent`, awaiting new `superagent` release." // https://github.com/ladjs/superagent/issues/1799
"expiry": "2024-10-22",
// Re-evaluate this vulnerability after this date.
"notes": "Transitive dependency of `superagent`, awaiting new `superagent` release."
// https://github.com/ladjs/superagent/issues/1799
// Vulnerability fix only available in `superagent@9.0.0+`: Please upgrade to v9.0.0+ as we have fixed a public vulnerability with formidable dependency. Note that v9.0.0+ requires Node.js v14.18.0+. See https://github.com/ladjs/superagent/pull/1800 for insight.
}
},
{
"GHSA-grv7-fg5c-xmjg|braces": {
"active": true,
"expiry": "2024-12-22", // Re-evaluate this vulnerability after this date.
"notes": "Transitive dependency of `chokidar` and `micromatch`"
// (`braces` -> `chokidar` -> `mocha`), chokidar unlikely to get patched: https://github.com/paulmillr/chokidar/issues/1301, mocha maintenance questionable: https://github.com/mochajs/mocha/issues/5027
// (`braces` -> `micromatch` -> `fast-glob` -> `globby` -> `typescript-eslint/typescript-estree`), micromatch is patched, but fast-glob not maintained: https://github.com/mrmlnc/fast-glob/issues/443
}
}
]
Expand Down

0 comments on commit 0ad903e

Please sign in to comment.