Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new post endpoint for regenerateRates #158

Merged
merged 5 commits into from Aug 25, 2021
Merged

use new post endpoint for regenerateRates #158

merged 5 commits into from Aug 25, 2021

Conversation

Roguelazer
Copy link
Contributor

The GET method is being made read-only in the future.

@Justintime50
Copy link
Member

jontsai
jontsai previously approved these changes Jun 1, 2021
Copy link
Contributor

@jontsai jontsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Justintime50
Copy link
Member

@Roguelazer could we get a rebase here? If tests pass we can get this merged in.

@Justintime50
Copy link
Member

I fixed the merge conflicts here but tests are failing because the function name changed. We'll need to have the tests adjusted @Roguelazer

Justintime50
Justintime50 previously approved these changes Aug 12, 2021
Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed up a fix for the tests, build passes now.

Sarahbear1926
Sarahbear1926 previously approved these changes Aug 16, 2021
ejachang
ejachang previously approved these changes Aug 16, 2021
jontsai
jontsai previously approved these changes Aug 16, 2021
@Justintime50 Justintime50 dismissed stale reviews from jontsai, ejachang, Sarahbear1926, and themself via 8c92bd1 August 25, 2021 15:53
@Justintime50 Justintime50 requested review from jontsai, Sarahbear1926 and ejachang and removed request for brentonjackson August 25, 2021 15:54
@Justintime50 Justintime50 merged commit d077092 into master Aug 25, 2021
@jontsai jontsai deleted the rerate branch October 8, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants