Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EndShipper beta class. #249

Merged
merged 2 commits into from May 18, 2022
Merged

Add EndShipper beta class. #249

merged 2 commits into from May 18, 2022

Conversation

jchen293
Copy link
Member

@jchen293 jchen293 commented May 16, 2022 •
edited

Description

Adds the new EndShipper beta class with retrieve, all, and save functions. This is the fully-qualified address object that the USPS will start requiring shortly.
Add BaseAddress propTypes that Address and EndShipper can use

Testing

Add unit tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@jchen293 jchen293 marked this pull request as ready for review May 16, 2022 20:27
Justintime50
Justintime50 requested changes May 16, 2022
View reviewed changes
Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's figure out these propTypes before merging

src/beta/easypost.js Outdated Show resolved Hide resolved
src/beta/resources/end_shipper.js Outdated Show resolved Hide resolved
test/resources/beta/end_shipper.test.js Outdated Show resolved Hide resolved
test/resources/beta/end_shipper.test.js Outdated Show resolved Hide resolved
test/resources/beta/end_shipper.test.js Outdated Show resolved Hide resolved
@jchen293 jchen293 merged commit 6fc81de into master May 18, 2022
@jchen293 jchen293 deleted the end_shipper branch May 18, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwithan8 nwithan8 nwithan8 approved these changes

@Justintime50 Justintime50 Justintime50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jchen293 @nwithan8 @Justintime50