fix: lowestSmartRate tests that are skipped #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Justintime50
force-pushed
the
unskip_tests
branch
from
1124396
to
eba9934
Compare
Justintime50
changed the title
nwithan8
previously approved these changes
Jan 20, 2023
nwithan8
approved these changes
Jan 20, 2023
jchen293
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For whatever reason, we had two tests (similar in logic) that VCR couldn't match properly. After a bunch of debugging, I found we could get around this by combining the two tests into a single cassette. Not ideal, but much better than just not testing this at all. This PR re-enables these tests and bumps the minimum coverage to match.
Testing
Pull Request Type
Please select the option(s) that are relevant to this PR.