-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CarrierAccount creation endpoint for UpsAccount and FedexAccount #229
Conversation
Hey @aryrabelo, thanks for your PR! We are making this change across our other libs too, funny timing you submitted this now. There is a bit of nuance with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty close. You can look at #231 for an example of what I'm thinking of and/or look at our Python/C#/Go libraries recent PRs where we just added this too.
If you can address these couple items of feedback, we can get this merged in and released. Thanks!
@aryrabelo are you able to make the adjustments suggested here? We'd like to get this in a release next week. We can make the adjustments next week if you aren't able. Thanks! |
@Justintime50 Sorry, I took a week off, pushing the changes now |
No worries! The code looks good; however, Ruby isn't getting setup correctly on CI. I pushed a fix for this problem last week that is on the master branch. If you can rebase this PR, we should be golden and we'll get this merged in. |
It appears that GitHub Actions is failing due to a new issue for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this PR! Can't wait to get your contribution into the project.
For future travelers, the CI build was failing due to ruby/psych#597. For now, I've pinned the previous version until this gets fixed for v5 of |
Your changes have been release in |
Description
This fixes CarrierAccount creation endpoint for UpsAccount and FedexAccount that according to the docs https://support.easypost.com/hc/en-us/articles/360041148012-FedEx-Account-Registration-Guide and https://support.easypost.com/hc/en-us/articles/360024355712-Setting-up-your-UPS-Account should be sent to a different endpoint.
Testing
Added tests
Pull Request Type
Please select the option(s) that are relevant to this PR.