Android: Fix write detection #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rite is not reliable
…ectory not writable
…am with log and saves attached. Update a few translation strings.
|
Is there a way to check if the email could be sent? Would make sense to display a message about manually reporting a bug if the user aborts the mail or something did not work. |
|
No. The only thing you can detect is if the user pressed back in the "select mail program" dialog. |
| <string name="save_and_quit">Save and quit</string> | ||
| <string name="save_and_quit">Save and quit</string> | ||
| <string name="key_enter">Enter (Z)</string> | ||
| <string name="key_cancel">Cancel (X)</string> |
There was a problem hiding this comment.
Please consider mentioning Esc too.
|
Well, then maybe an explanatory message before is better.
|
|
@carstene1ns done |
fdelapena
added a commit
that referenced
this pull request
Jan 17, 2016
Android: Fix write detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #726
Also adds logic to copy saves from game dir to save dir if save dir has no saves yet. (otherwise people will complain that saves got lost after copying games to external storage)
Also adds bug Report function to ingame menu