Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vcpkg: Add Freetype[core]. Prevents the build of bzip2. #58

Merged
merged 1 commit into from Apr 3, 2020

Conversation

Ghabry
Copy link
Member

@Ghabry Ghabry commented Apr 2, 2020

Freetype learned feature selection a while ago, so we can get rid of bzip2 :)

@carstene1ns carstene1ns merged commit 5c39b3d into EasyRPG:master Apr 3, 2020
@Ghabry
Copy link
Member Author

Ghabry commented Apr 3, 2020

Freetype[core] is enough to build harfbuzz[ucdn] but the depedency resolution has a bug and still installs bzip2 when you install both at once :/

I filed a bug here: microsoft/vcpkg#10678

@Ghabry Ghabry deleted the vcpkg branch April 3, 2020 15:29
@carstene1ns
Copy link
Member

Can we work around this when we do the install in 2 steps (seperate install lines)?

@Ghabry
Copy link
Member Author

Ghabry commented Apr 4, 2020

Yes this is what I used for the testing (and why I didn't notice this but)

@carstene1ns
Copy link
Member

Bug is closed as WontFix, does freetype[core] harfbuzz[core,ucdn] freetype[core] work for us?
Also, minor thing: We have stray carets in the list now ( ^).

@Ghabry
Copy link
Member Author

Ghabry commented Apr 29, 2020

nope, specifying freetype twice doesn't help. Is always ignored.

No idea how this can't be a bug (or they just don't understand what I want -_-) but okay.....

> vcpkg.exe --triplet x86-windows install freetype[core] harfbuzz[core,ucdn]
Computing installation plan...
The following packages will be built and installed:
  * bzip2[core]:x86-windows
    freetype[bzip2,core,png]:x86-windows
    harfbuzz[core,ucdn]:x86-windows
  * libpng[core]:x86-windows
  * ragel[core]:x86-windows
  * zlib[core]:x86-windows

> vcpkg list
bzip2:x86-windows                                  1.0.6-5
freetype:x86-windows                               2.10.1-6
freetype[bzip2]:x86-windows
freetype[png]:x86-windows
harfbuzz:x86-windows                               2.5.3
harfbuzz[ucdn]:x86-windows 
libpng:x86-windows                                 1.6.37-7
ragel:x86-windows                                  6.10-3
zlib:x86-windows                                   1.2.11-6
> vcpkg.exe --triplet x86-windows install freetype[core]
Computing installation plan...
The following packages will be built and installed:
    freetype[core]:x86-windows
  * zlib[core]:x86-windows
  
> vcpkg.exe --triplet x86-windows install harfbuzz[core,ucdn]
Computing installation plan...
The following packages will be built and installed:
    harfbuzz[core,ucdn]:x86-windows
  * ragel[core]:x86-windows

> vcpkg list
freetype:x86-windows                               2.10.1-6
harfbuzz:x86-windows                               2.5.3
harfbuzz[ucdn]:x86-windows
ragel:x86-windows                                  6.10-3
zlib:x86-windows                                   1.2.11-6

@Ghabry
Copy link
Member Author

Ghabry commented Apr 29, 2020

The bug I reported is actually a different bug in the dependency resolution. When they fix it it will always install bzip2 and libpng.

The actual bug is a problem with the harfbuzz portfile. See my last comment here. Will submit a patch.

microsoft/vcpkg#10678 (comment)

@Ghabry
Copy link
Member Author

Ghabry commented Apr 30, 2020

My patch to harfbuzz was just merged, so this PR will work as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants