Fix savegame corruption introduced in 5abb593d #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carstene1ns
approved these changes
Apr 12, 2017
|
Yepp I just noticed that I didn't even revert the broken line >.< |
… savegames triggers an assert in Scene_Load in EasyRPG, breaking the scene completely.
|
We are actually lucky that the event data is the last in the savefile, so loading such a corrupted save fixes itself in most cases by simply reentering the map 👍 (not possible with Yume Nikki, stuck at "Loading: Please Wait" SE preload). Tested with VH1, Yume2kki and Yume Nikki: The save/load scene opens without crashing and after loading the broken save and resaving the errors are gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the asserts and changed the error handling a bit because the broken event commands are reallllly bad and result in an assert when opening Scene_load or Scene_Save otherwise :(
Fixes EasyRPG/Player#1149.