Remove MSVC project #294
Merged
Remove MSVC project #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't merge this yet, decided that I will also attach the CMake issues I found here. (also applies to Player) |
|
Sure,may also have some further ideas. |
|
In another issue I wrote about Ehsc: But this isn't the issue this time... |
|
the Ehsc issue was resolved by removing that bigobj switch, because I forgot to use APPEND that property overwrote all compiler flags.......... Which means I'm done here |
carstene1ns
reviewed
Dec 8, 2018
carstene1ns
approved these changes
Dec 8, 2018
fdelapena
approved these changes
Dec 8, 2018
carstene1ns
approved these changes
Dec 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guess nobody will miss these XML files. ✨🎈🎉🎆
All Jenkins jobs already use CMake, everything should work as before even without this merged.