Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MSVC project #294

Merged
merged 4 commits into from Dec 9, 2018

Conversation

Projects
None yet
3 participants
@Ghabry
Copy link
Member

Ghabry commented Dec 7, 2018

Guess nobody will miss these XML files. 🎈🎉🎆

All Jenkins jobs already use CMake, everything should work as before even without this merged.

@Ghabry Ghabry added the Building label Dec 7, 2018

@Ghabry Ghabry added this to the 0.6.0 (likely) milestone Dec 7, 2018

@Ghabry Ghabry force-pushed the Ghabry:msvc-wipe branch from 58c9d34 to 4b120d4 Dec 7, 2018

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Dec 7, 2018

Please don't merge this yet, decided that I will also attach the CMake issues I found here. (also applies to Player)

@carstene1ns

This comment has been minimized.

Copy link
Member

carstene1ns commented Dec 7, 2018

Sure,may also have some further ideas.

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Dec 7, 2018

In another issue I wrote about Ehsc:

EasyRPG/Tools#30 (comment)

But this isn't the issue this time...

@Ghabry

This comment has been minimized.

Copy link
Member Author

Ghabry commented Dec 7, 2018

the Ehsc issue was resolved by removing that bigobj switch, because I forgot to use APPEND that property overwrote all compiler flags..........

Which means I'm done here

Show resolved Hide resolved .gitignore Outdated

@Ghabry Ghabry force-pushed the Ghabry:msvc-wipe branch from 1fe692b to 505fea0 Dec 8, 2018

Show resolved Hide resolved README.md Outdated

@Ghabry Ghabry force-pushed the Ghabry:msvc-wipe branch from 505fea0 to f7a02aa Dec 8, 2018

@carstene1ns carstene1ns merged commit 21257b4 into EasyRPG:master Dec 9, 2018

5 checks passed

GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii Build finished.
Details
Windows Build finished.
Details
web Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.