Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lcf::Data out of parser implementations #405

Merged
merged 3 commits into from
Oct 16, 2020

Conversation

fmatthew5876
Copy link
Contributor

@fmatthew5876 fmatthew5876 commented Oct 9, 2020

Preparation for removing globals from liblcf. This change only moves lcf::Data out to the edges. Player and Editor are not affected by this.

Next PR will remove lcf::Data

TBD:

  • Test reading/writing 2k and 2k3 LDB, LMT, LMU, LSD files to ensure no breaks

@fmatthew5876
Copy link
Contributor Author

I tested this on some lcf files, the outputs match exactly. This is ready.

@Ghabry
Copy link
Member

Ghabry commented Oct 15, 2020

did you use this 1500 LDB files collection from rmarchiv?

I wanted to run a test with them but somehow can't find the script anymore.
I slowly consider setting up a test on jenkins that does this for me...

@fmatthew5876
Copy link
Contributor Author

I have about 40 games 2k and 2k3 on my hard drive right now.
I just made bench_readldb save the ldb back to disk and ran this:

for x in 2k3/*/*.ldb; do ./bench_readldb "$x"; md5sum "$x" out.ldb; done

All compared exactly.

@Ghabry
Copy link
Member

Ghabry commented Oct 16, 2020

2269 LDB, 2269 LMT, 4229 LMU and 722 LSD later: The hashes match. (also the mismatches match, more on this later)

@Ghabry Ghabry merged commit dfda005 into EasyRPG:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants