Merge pull request #354 from adangel:cleanup-audio-mixer

Unregister Mixer Control when extension is disabled #354
EasyScreenCast · Oct 14, 2023 · 1482f08 · 1482f08
2 parents ec538ac + 341389c
commit 1482f08
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,9 +12,12 @@ need to be used.
 
 * [#347](https://github.com/EasyScreenCast/EasyScreenCast/pull/347): Add czech translation ([@Amereyeu](https://github.com/Amereyeu))
 * [#353](https://github.com/EasyScreenCast/EasyScreenCast/pull/353): Support Gnome 45 ([@adangel](https://github.com/adangel))
+* [#354](https://github.com/EasyScreenCast/EasyScreenCast/pull/354): Unregister Mixer Control when extension is disabled ([@adangel](https://github.com/adangel))
 
 **🐛 Fixed bugs:**
 
+* [#349](https://github.com/EasyScreenCast/EasyScreenCast/issues/349): With no pipewire, "ESC Mixer Control" may fill up all pulseaudio connections in seconds and break sound for all apps ([@ell1e](https://github.com/ell1e))
+
 **📦 Dependency updates:**
 
 * [#348](https://github.com/EasyScreenCast/EasyScreenCast/pull/348): Bump word-wrap from 1.2.3 to 1.2.4 ([@dependabot](https://github.com/apps/dependabot))

diff --git a/extension.js b/extension.js
@@ -610,6 +610,8 @@ const EasyScreenCastIndicator = GObject.registerClass({
         this._removeKeybindings();
         // stop monitoring inputvideo
         this.CtrlWebcam.stopMonitor();
+        // unregister mixer control
+        this.CtrlAudio.destroy();
 
         // remove indicator
         this.remove_actor(this.indicatorBox);