Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to ScreencastIface causes warning in logs #277

Closed
Ian2020 opened this issue Oct 7, 2020 · 2 comments
Closed

Access to ScreencastIface causes warning in logs #277

Ian2020 opened this issue Oct 7, 2020 · 2 comments

Comments

@Ian2020
Copy link
Collaborator

Ian2020 commented Oct 7, 2020

Expected Behavior

Clean logs.

Current Behavior

The following appears in the logs:

Some code accessed the property 'ScreencastIface' on the module 'screencast'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.

Possible Solution

@somethingGoneWrong suggested a possible solution in #272. Gnome-shell maintainers commented also that loadInterfaceXML('org.gnome.Screencast') should be used and added: "As a bonus, that change will also work on 3.38, while the current code breaks (because screencasting was split out into a separate process)."

Steps to Reproduce (for bugs)

  1. Enable the extension, start a GNOME session
  2. Check your logs: journalctl -b0 | grep ScreencastIface

Logs

Above.

Your Environment

  • Where did you download the extension?
    [ ] Gnome shell extension website
    [X] From Git (3252312)

  • Gnome shell version: 3.36.6

  • Operating System and version: Fedora 32

  • Display server: X11

@Ian2020
Copy link
Collaborator Author

Ian2020 commented Oct 7, 2020

Changing the code at the top of utilrecorder.js to this resolves the issue:

...
const { loadInterfaceXML, loadSubInterfaceXML } = imports.misc.fileUtils;
const ScreencastIface = loadInterfaceXML('org.gnome.Shell.Screencast');
...
const ScreenCastProxy = Gio.DBusProxy.makeProxyWrapper(
    ScreencastIface
);
...

...however @somethingGoneWrong said this could be hacky. I can submit PR though if this is suitable solution?

@Ian2020
Copy link
Collaborator Author

Ian2020 commented Apr 12, 2021

I think this has been resolved by merging #276

@Ian2020 Ian2020 closed this as completed Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant