Allow extension to load under GNOME 3.38

[Ian2020]

Fix for #275. I don't know if this will break older users however(?)

[doronbehar]

@lan2020 does this fix the extension for you with Gnome 3.38?

[Ian2020]

I am blocked from finishing my testing in GNOME 3.38 by #281 unfortunately. My change however does fix the missing screencast module import problem which is also part of the cause of issues #272, #277 and #281 I think.

Under GNOME 3.38 the next problem I hit is that Tweener has also been dropped in GNOME shell: by this change. I managed to make a fix for that too but then hit another issue:

JS ERROR: Extension EasyScreenCast@iacopodeenosee.gmail.com: TypeError: meta is null
_createMIInfoDelayRec@/home/ian/.local/share/gnome-shell/extensions/EasyScreenCast@iacopodeenosee.gmail.com/extension.js:609:28
_add_recording_delay_sub_menu@/home/ian/.local/share/gnome-shell/extensions/EasyScreenCast@iacopodeenosee.gmail.com/extension.js:346:26
_init_main_menu@/home/ian/.local/share/gnome-shell/extensions/EasyScreenCast@iacopodeenosee.gmail.com/extension.js:140:14
_init@/home/ian/.local/share/gnome-shell/extensions/EasyScreenCast@iacopodeenosee.gmail.com/extension.js:118:14
enable@/home/ian/.local/share/gnome-shell/extensions/EasyScreenCast@iacopodeenosee.gmail.com/extension.js:1017:21

I had updated metadata.json to add "3.38" to shell-version but still no joy. Any help appreciated! See my additional changes here (github.com)

[doronbehar]

@lan2020 have you encountered this thread by any chance:

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3264

?

[Ian2020]

Ah perfect! Thank you for finding that, that was the clue I needed. I have now got the extension appearing under GNOME 3.38 and confirm the deprecation warnings are absent.

Now I am able to test the extension but it fails when I start to record:

pipewire[21707]: [E][000158167.393563][module-access.c:102 check_flatpak()] failed to open "/proc/194377/root": Permission denied
pipewire[21707]: [W][000158167.393580][module-access.c:195 context_check_access()] access 0x563b66a89d30: client 0x563b66b87430 sandbox check failed: Permission denied

I am on Fedora 33, possibly this is a separate issue, perhaps my changes so far will work for others.

[doronbehar]

Indeed that can be a distro specific issue: https://bbs.archlinux.org/viewtopic.php?id=254217

Or perhaps you need to enable the pipewire systemd service: https://wiki.archlinux.org/index.php/PipeWire .

I'd be delighted to test this patch here on NixOS but I haven't done it yet.

[Ian2020]

I checked and pipewire services are running - I think I am suffering a variation of pipewire's bug #270 which might not yet be fully fixed. Will take a closer look there.

[Ian2020]

The extension now loads and works ok for me with the commit I just added. I still have pipewire errors in the logs but this last small change to the extension was all that was needed. I have hacked around a seemingly small problem with a missing _screencast indicator that was the final blocker. A proper solution is needed but if this works for others then maybe somebody can advise what the real fix is. Am also discussing this in #281 where I'll ask for more testing too.

[grahamwhiteuk]

I can confirm, as per #281, that this PR works and allows the extension to work under Gnome 3.38 (as tested on Gnome 3.38.1 on Fedora 33).

[doronbehar]

Works for me too, here on NixOS (with NixOS/nixpkgs#104888 ).

[cubells]

This not solve my problem: #272

Sorry.

Error I've got is:

"Nov 26 11:29:53 portatil gnome-shell[42718]: [ESC]-&-ERROR(screencast execute) - GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.gnome.Shell.Screencast was not provided by any .service files"

[diegovasconcelos]

#276 Work for me (Fedora 33 - Wayland)

[Ian2020]

@cubells: from #272 it looks like you're on GNOME 3.38.0 perhaps? Are you able to try with 3.38.1, maybe some of fixes that went into that version are useful: news.

[cubells]

@Ian2020 I'm now in gnome 3.38.1 and it does not work.

[Ian2020]

I'll get a Ubuntu environment and investigate. I see also in #272 that @epozuelo and @somethingGoneWrong already did some work to resolve this so will look at their changes.

[Haxk20]

Im getting GDBus.Error:org.freedesktop.DBus.Error.NoReply: Message recipient disconnected from message bus without replying when trying to screencast using the extension.

This is on Gentoo

[pluizetto]

@Ian2020 I'm now in gnome 3.38.1 and it does not work.

For me too - Fedora 33

[Ian2020]

• @cubells I have reproduced the failure you found on Ubuntu now, will try and fix if I can.
• @pluizetto - silly question but can I confirm you have applied the latest patched code of this PR and re-tested? So far others on Fedora 33 are ok. What error are you seeing? The one you posted last: ReferenceError: global is not defined should be gone now.

[pluizetto]

* @cubells I have reproduced the failure you found on Ubuntu now, will try and fix if I can.

* @pluizetto - silly question but can I confirm you have applied the latest patched code of this PR and re-tested? So far others on Fedora 33 are ok. What error are you seeing? The one you posted last: `ReferenceError: global is not defined` should be gone now.

Silly question, but very important! I was not actually downloading the files from this PR, but those from the original repo. I'm sorry for this mistake, I don't use Git much. Now everything is ok! Thank you for this PR.

[Ian2020]

@cubells - I think you are suffering a Ubuntu 20.04 specific issue which has been logged and is for their packagers to resolve: https://bugs.launchpad.net/ubuntu/+source/xdg-desktop-portal/+bug/1879580. The files that declare the Screencast interface this extension uses are not present under Ubuntu at present unfortunately.

[cubells]

@Ian2020 ok, I'll review this bug and I'll do some test and I'll come back here to say something.

[cowlicks]

@cubells any updates?

[samueloph]

Thanks for the fix @Ian2020, I have packaged your patch for Debian as part of the 1.1.0+git20210116.3252312-1 release. Hopefully upstream will be able to merge it.

[jspaleta]

Hey!
Fedora 33 user using latest updates including gnome-shell-3.38.3-1.fc33.x86_64

Interesting.. I can get it to record the screen, but trying to enable the integrated webcam and it throws errors. Once I have enabled webcam recording...unable to deselect the webcam in the controls.. I have to restore defaults and then restart the gnome shell.

audio recording is working.

[tobias47n9e]

Thanks for y'alls effort