Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sessionMode updated signal in Capture class #331

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

meghprkh
Copy link
Contributor

@meghprkh
Copy link
Contributor Author

meghprkh commented Apr 20, 2022

However this is an untested blind change from my side and needs verification from someone who actually understands the code.

This was suggested as part of review https://extensions.gnome.org/review/31701

@adangel adangel added this to the next milestone Aug 3, 2022
@adangel
Copy link
Collaborator

adangel commented Aug 3, 2022

Thanks for the PR and sorry for the late response...

I think, it might be better to remove the code - I don't know why EasyScreenCast is registering a handler when the session mode is changed: The only thing we do here is logging:

EasyScreenCast/selection.js

Lines 114 to 116 in ae0d1f3

_updateDraw() {
Lib.TalkativeLog('-£-update draw capture');
}

We also don't support running while the screen is locked (no parameter "session-modes" in metadata.json ...).

So I see no reason why to call Main.sessionMode.connect('updated'... at all.

@meghprkh
Copy link
Contributor Author

Thanks @adangel , updated the PR

Copy link
Collaborator

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adangel adangel changed the title Disconnect sessionMode updated signal in Capture class Remove sessionMode updated signal in Capture class Aug 23, 2022
adangel added a commit that referenced this pull request Aug 23, 2022
Remove sessionMode updated signal in Capture class #331
@adangel adangel merged commit 2b26b6d into EasyScreenCast:master Aug 23, 2022
@adangel adangel modified the milestone: next Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants