Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expansion to GF Cyrillic Plus, Pro, and localised glyphs #34

Merged
merged 33 commits into from
Nov 30, 2016
Merged

Expansion to GF Cyrillic Plus, Pro, and localised glyphs #34

merged 33 commits into from
Nov 30, 2016

Conversation

alexeiva
Copy link
Contributor

@alexeiva alexeiva commented Sep 8, 2016

@EbenSorkin This is work in progress, please don't merge yet.

@alexeiva
Copy link
Contributor Author

Now mastering and finalising the sources.

Please don't merge this yet.

@alexeiva
Copy link
Contributor Author

@EbenSorkin This is good to merge now

@alexeiva
Copy link
Contributor Author

I have fixed some minor interpolation issues in the fonts, in connection with sources convertion to glyphs app.

There remains a problem I don't know how to fix yet.

Previous version — no ccmp = no problem
screen shot 2016-10-20 at 14 13 36

New Glyphs version Regular — ccmp works fine

screen shot 2016-10-20 at 14 14 10

New Glyphs version Italic — ccmp doesn't work properly

screen shot 2016-10-20 at 14 14 18

@alexeiva
Copy link
Contributor Author

/cc @kalapi @schriftgestalt Do you know why the Aringacute isn't placed properly? This glyph isn't in the font, but is produced thru mark positioning.

https://github.com/alexeiva/Merriweather/blob/master/sources/Merriweather-Italic.glyphs

@kalapi
Copy link

kalapi commented Oct 21, 2016

@alexeiva The combining marks in the italics don't have a 'top' anchor and thus no resulting mkmk. Also, not entirely connected, the combining marks have advance widths (in both sources).

@alexeiva
Copy link
Contributor Author

@kalapi Thanks, will try that.
Combining marks have advanced widths in sources, but on TTF export glyphs zeros them automatically.

@schriftgestalt
Copy link

Also, not entirely connected, the combining marks have advance widths (in both sources).
Yes, as @alexeiva said, on export, they are set to zero width. Zero width glyphs are difficult to edit in Glyphs because they sit on top of each other in the edit view.

@davelab6
Copy link
Contributor

@alexeiva what is the status of this? waiting for @EbenSorkin to merge?

@alexeiva
Copy link
Contributor Author

@davelab6

Just made a fix for Aringacute. This is ready to merge now

screen shot 2016-10-28 at 00 17 12

@EbenSorkin EbenSorkin merged commit 44e75ec into EbenSorkin:master Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants