-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-functional since Pale Moon 29.4.0? #16
Comments
Same here, I just wanted to open an issue. I can open the settings throught the addons tab, but I cannot close the settings popup by clicking Ok or Cancel, just by clicking the X on top right. |
Here are some more clues about this issue:
|
And brand new, I quote from
|
The non-functionality issue has temporarily been suspended by the issue-specific hotfix release 29.4.0.1 of Pale Moon (https://forum.palemoon.org/viewtopic.php?t=27276&p=219262#p219262) but as the release announcement states, "please update your extension before the next major release". Note that the issue itself is NOT fixed, just temporarily worked around and will reoccur when the mentioned "FUEL component" is removed again, |
All hacks and troubleshootings are really obsolete now, as with Pale Moon 29.4.2 the support for FUEL is finally scrapped. |
This is extremely unfortunate. If anyone has a suggestion for a workaround in Pale Moon or does decide to fork/develop a new extension with similar functionality to that of NoSquint, please consider notifications to this problem report very much welcome! |
The Pale Moon people claim that it ought to be an easy-peasy, super-simple, just stop whining and go ahead and do it fix to make NoSquint compatible again. But looking at the source code and js files, I am daunted. Does anyone else have more of a clue than I do? |
Check this post, and the following ones: https://forum.palemoon.org/viewtopic.php?f=3&t=27261&start=20#p219618 |
@Gittyperson well, this is the outdated info you're referring to. btw at least I was involved in those posts. |
there are some other legacy firefox addons we might be able to use. I remember I used one called zoom page. Now it's called zoom page we. But I don't know where we can find those legacy addons. |
You can find most of them here: |
That is a combined xpi file with a big sqlite life in it. Is there a way to just separate one of the addons out of that file? |
oh, never mind. I figured it out. Need to install it first to get other addons. thank you. |
ok, I don't think we need no squint anymore. I changed the ID of two other addons. One is called global zoom - you can set zoom setting for one tab and it applies to all other tabs. |
I still believe we need as Pale Moon users -not individually since NoSquint has been made to work, too- at least one zoom manager extension in the Pale Moon Add-ons Site, and NoSquint is the best of the bunch. |
I agree that we need at least one zoom manager extension in the Pale Moon add-ons site, and that NoSquint is the best of the bunch. But someone needs to keep it up-to-date as the Pale Moon developers change things in ways that make the old extensions stop working. It's not just changing the ID; the plan, according to the Pale Moon forum, is to drop the use of install.rdf files in favor of some JSON thing. And other changes can be expected to come around and bite the old extensions at any time, the way dropping FUEL did to NoSquint. And pace MoonChild it has to be someone who can program. (He claims "Almost all extensions were made by "consumers" of Firefox. Updating isn't even close to making one from scratch. If they could, you can. Regular people made this, not some wizards of coding." But this is not the case. The extensions were created by a specially skilled subset of Firefox users who were actually wizards of coding.) |
Hi. I use pentadactyl and is so happens pentadactyl leaves a clue. I'm no programmer but just by searching trough the source folder I find references to nosquint.prefs I guess some of the other extension managers could manage to figure it out if there is no reaction on this from EbonJaeger. |
I believe it has already been figured out and fixed, for personal use only at the moment. You just need to look at the Pale Moon forum links above. |
It could be very helpful if someone would please summarize this referenced fix here or link to a concise summary elsewhere, as reading through long threads of text can be extremely exhausting at best for visually impaired people, probably a primary user group of NoSquint. |
EDIT For reference, this is the supposed "fix" that I question the validity of: https://forum.palemoon.org/viewtopic.php?f=3&t=27261&start=20#p219622 It should really be worth noting that the aforementioned fix was NOT tested on 29.4.0 (only on 29.4.0.2... the version where stock NoSquint already worked) and, from my own testing whereby AFAICT I did everything 100% correctly, the supposed "fix" doesn't actually make the extension work... or at least function enough to the point of being actually usable. (for reference, despite my inability to code as hardware is my specialty rather than software, I am at least quite computer savvy and am able to poke around config and/or script files and the like) Now I don't want this to be taken as gospel as, like I said, I can't code worth a darn so it's extremely possible that I did in fact screw up the process. However, as someone that is extremely OCD when it comes to doing any sort of testing, the fact that it wasn't even tested on 29.4.0 raises huge red flags for the validity of the supposed "fix" (I mean, it's not like it was difficult to test when portable versions of v29.4.0 are made available in the "archived versions" which is what I used for trying out the supposed "fix"). |
Obviously this is a very loved extension and I am happy to see the action here in the middle of the night, gathering around the fire for their fix. |
For what it's worth, I'm running PM 29.4.2 (not 29.0.2) and the "fixed" version is working for me. |
The NoSquint issue was caused by the sensible removal of the very old FUEL component. From the PM release notes: "...the optional FUEL component (long since deprecated precursor to the Mozilla Add-On SDK) was removed from Pale Moon" This fix by astewart on the Pale Moon forum involves editing two files. On init.js, the code described here needs to be added near the end of the file (where to add it is perhaps irrelevant). On lib.js, the instructions are here. That code needs to replace the corresponding original lines, and also an additional simple text search/replace operation is required. Application.storage.get becomes NSQApp.storage.getItem That's it. |
I made the mistake to do a search and replace of .get to .getItem and .set to .setItem.. in lib.js So why not only make a pull request in this repo? Will it not validate? Is this just negativity or are an "deeper" solution necessary? |
Maybe someone that believes themself to have acquired a completely successful implementation of the required fix could even post a diff output here, |
If possible, give me a quick guide on how to do that and I might attempt it later. Thanks. |
This seems like a good guide for beginners on how to create a diff-file, |
Well, all this fuss still does not make it work on Pale Moon 29.4.2.1 |
Thanks b9AcE. I've created the two patch/diff files below using WinMerge. It seems they correctly indicate the differences between the original and patched files. Now, I'm not sure what the heck I can do with them here on Github, apart from merely attaching them on a comment (which I haven't, yet). init.js.patch |
By the way, I extracted the nosquint.jar file (which contains init.js and lib.js) because WinMerge didn't seem to like working directly on it. |
Not sure if necessary, but before installing the patched NoSquint I recommend to:
|
Thank you, @Gittyperson! |
My lack of software-dev & command-line skills are making me have trouble using these patch files... Think you could make one in the BPS or xDelta patch format instead? Also it's unclear what file we're supposed to be patching - is it the v2.2.2 XPI file directly? Maybe things are different in the software-dev world, but as someone with a background more in retro game console modding, I've found the patch formats IPS, BPS, and xDelta to be much more commonly used and have a slew of GUI patchers and patch-creation software for them, including even a browser-based one: http://www.marcrobledo.com/RomPatcher.js/ (I generally would recommend using BPS or, for larger 1+GB files, xDelta; IPS is a legacy format that, much like MP3 and GIF, is only still widely used due to inertia) |
It looks to be just a standard git diff. To apply it, you would clone the repo, and run
The standard way to submit changes to a git project (on GitHub, tho the flow is the same for any other repository hosting like GitLab) is to:
All that said, ideally someone who wants to maintain this should fork this repo, do anything necessary, and work with PM for ownership. I moved on from Pale Moon years ago and have no desire to be a part of... all of that. |
The user back2themoon on the forum sounds like they may be interested in such a thing: EDIT At least temporarily,, Tobin is taking what he calls "casual charge" for the time being: |
I've done that to clean up the super ancient code of issue 3, as best I could as a first-time newbie. That ancient code is also a small part of this issue. My changes work on PM 29.4.0.1 at least as well as the hard-code the variables hack, but I suspect that there are still bits of cleanup I missed.
I'm mildly tempted to "work with PM for ownership" just to make Moonchild eat crow about his "If they could, you can. Regular people made this, not some wizards of coding." But I'm not in for being yelled at when things get screwed up because I'm in over my head. |
That is true for patching binary files, but .diff has been the main, near only, format for patching pure text files and similar such as source code for oh, about 50 years. Here's something I wrote for you now:
|
From the release notes of newly released Pale Moon version 29.4.3:
So, presumably this should mean this issue is now indefinitely no longer an issue, |
I tried the "fuel fixed" version with Pale Moon 29.4.3 - it does not work. Edit: |
I already tried removing the modified version of NoSquint and reinstalling it from https://addons.palemoon.org/addon/nosquint/ and it all works again for me, including remembering previous zoom levels. |
Well, it's been 6 days since FUEL was rolled back into Pale Moon and nobody added any outstanding problems here, so I will hereby close this issue considering it resolved. |
I have been using this extension for many years and it has been extremely helpful for me as I am visually impaired.
However, when the Pale Moon update for version 29.4.0 was applied, it seems that made NoSquint version 2.2.2 lose most of its functionality.
For example:
I am not aware of any of these issues being present in the previous Pale Moon version.
Hoping for a quick fix to this extension's functionality, as I rely on it quite heavily since becoming visually impaired.
Thank you!
The text was updated successfully, but these errors were encountered: