Improve repo #3148
Merged
Improve repo #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is definitely something we have needed. I'm going to accept this even though I can't read it; Chinese reading users, please comment, even if it's just "LooksGoodToMe". |
|
LGTM, even though some unnecessary space in content. |
|
Thanks @zhongjiajie ! |
ruimartinsptl
pushed a commit
to ruimartinsptl/free-programming-books
that referenced
this pull request
May 22, 2019
* remove 2 ebook of [Linkers and Loaders], [Learn Python The Hard Way]. ref issue:EbookFoundation#3091, EbookFoundation#3062 * Add CONTRIBUTING file of chinese version. * Format text, update some description * translate contribution md file. * Add open Issue ref link * Update some description in CONTRIBUTING And CONTRIBUTING-zh file. * Update some description of zh version CONTRIBUTING. * format md code to pass Travis CI check * Fix The Travis CI check issue * Fix The Travis CI check issue * Fix The Travis CI check issue * format md file to pass TCI check.
ShamimWP
pushed a commit
to ShamimWP/free-programming-books
that referenced
this pull request
Dec 3, 2019
* remove 2 ebook of [Linkers and Loaders], [Learn Python The Hard Way]. ref issue:EbookFoundation#3091, EbookFoundation#3062 * Add CONTRIBUTING file of chinese version. * Format text, update some description * translate contribution md file. * Add open Issue ref link * Update some description in CONTRIBUTING And CONTRIBUTING-zh file. * Update some description of zh version CONTRIBUTING. * format md code to pass Travis CI check * Fix The Travis CI check issue * Fix The Travis CI check issue * Fix The Travis CI check issue * format md file to pass TCI check.
DejanPerovic
pushed a commit
to DejanPerovic/free-programming-books
that referenced
this pull request
Dec 18, 2019
* remove 2 ebook of [Linkers and Loaders], [Learn Python The Hard Way]. ref issue:EbookFoundation#3091, EbookFoundation#3062 * Add CONTRIBUTING file of chinese version. * Format text, update some description * translate contribution md file. * Add open Issue ref link * Update some description in CONTRIBUTING And CONTRIBUTING-zh file. * Update some description of zh version CONTRIBUTING. * format md code to pass Travis CI check * Fix The Travis CI check issue * Fix The Travis CI check issue * Fix The Travis CI check issue * format md file to pass TCI check.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve Repo
Description
Add a chinese version CONTRIBUTING file that based on english version CONTRIBUTING file.
I found some chinese developers are not very clear how to open a correct PR, there will be some issues and it can't be checked pass by Travis CI, that is usually attributed to contributors not read the CONTRIBUTING carefully. so I create a zh version CONTRIBUTION To help them.