Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Link from Pro Git to new book version #3153

Merged
merged 3 commits into from Feb 25, 2019
Merged

Updated Link from Pro Git to new book version #3153

merged 3 commits into from Feb 25, 2019

Conversation

iambastian
Copy link
Contributor

@iambastian iambastian commented Feb 22, 2019

This PR is a copy from #3152. I deleted my fork after pull so the update didn't integrate into my previous PR. @bluetata

What does this PR do?

For the german book "Pro Git" is a new version available. Updated the link for it.

For resources

Description

Why is this valuable (or not)

How do we know it's really free?

License notes are on the first page available.

For book lists, is it a book?

Checklist:

  • Not a duplicate
  • Included author(s) if appropriate
  • Lists are in alphabetical order
  • Needed indications added (PDF, access notes, under construction)

Copy link
Contributor

@bluetata bluetata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~awesome 👍

@eshellman
Copy link
Collaborator

Maybe it would be good to list both versions, since the v1 translation is smore complete than the v2 version; also maybe add a german "in-progress" annotation (see CONTRIBUTING.md)

@bluetata
Copy link
Contributor

bluetata commented Feb 25, 2019

According to the CONTRIBUTING.md:

image

I suggest you can try to change it from

* [Pro Git 2009](http://git-scm.com/book/de/v1)
* [Pro Git - neue Version](http://git-scm.com/book/de/current) (:construction: *in process*)

to

* [Pro Git 1st Edition (2009)](http://git-scm.com/book/de/v1)
* [Pro Git 2nd Edition (2014)](http://git-scm.com/book/de/current) (:construction: *in process*)

<!-- or  -->

* [Pro Git (2009)](http://git-scm.com/book/de/v1)
* [Pro Git (neue Version)](http://git-scm.com/book/de/current) (:construction: *in process*)

<!-- or  -->

* [Pro Git (2009)](http://git-scm.com/book/de/v1)
* [Pro Git (2014)](http://git-scm.com/book/de/current) (:construction: *in process*)

@iambastian
Copy link
Contributor Author

I took the 2nd suggestion, because the current-tag does not guarantee, that v2 will ever be the newest version. Thank you!

@eshellman
Copy link
Collaborator

Thanks, and welcome to free-programming-books!

@eshellman eshellman merged commit 64d180f into EbookFoundation:master Feb 25, 2019
@iambastian iambastian deleted the patch-1 branch February 25, 2019 14:44
ruimartinsptl pushed a commit to ruimartinsptl/free-programming-books that referenced this pull request May 22, 2019
* Updated Link from Pro Git to new book version

* Update free-programming-books-de.md

* Update free-programming-books-de.md
ShamimWP pushed a commit to ShamimWP/free-programming-books that referenced this pull request Dec 3, 2019
* Updated Link from Pro Git to new book version

* Update free-programming-books-de.md

* Update free-programming-books-de.md
DejanPerovic pushed a commit to DejanPerovic/free-programming-books that referenced this pull request Dec 18, 2019
* Updated Link from Pro Git to new book version

* Update free-programming-books-de.md

* Update free-programming-books-de.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants