Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move a playground link to CSS section #3697

Merged
merged 4 commits into from
Sep 3, 2020

Conversation

jgpacker
Copy link
Contributor

@jgpacker jgpacker commented Sep 2, 2020

FlexBox is a CSS feature.
This move is consistent with other files.

What does this PR do?

Improve Repo

jgpacker added 2 commits September 2, 2020 18:27
FlexBox is a CSS feature.
This move is consistent with other files.
@eshellman
Copy link
Collaborator

I agree with moving the link. linter wants x to come after u. The broken link is not yours- fixing it is optional.

@borgified
Copy link
Contributor

hi, sorry for jumping in, just wanted to check with @eshellman to see how the new check is looking. is it serving its purpose or is it confusing folks?

@jgpacker
Copy link
Contributor Author

jgpacker commented Sep 3, 2020

@borgified from my perspective:

  • It can be confusing to have checks from Travis CI and Github Actions at the same time, because each check has logs in a different place (by the way, thanks for the comment @eshellman ).
  • As far as I understood, check_urls checks URLs only from files changed in the pull request. I think that's neat! I recommend making this clearer, by changing it's name from check_urls to something like Check URLs from changed files.

@eshellman
Copy link
Collaborator

Thank you @jgpacker, both for your PR and your perspective on check_urls.

@borgified I think that running check_urls is really useful, but returning a "fail" is not helpful. added urls get checked for content anyway. can the results of check_urls could be recorded in a separate file somehow?

@eshellman eshellman merged commit 41cb40b into EbookFoundation:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants