Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs)!: Ukrainian language code is uk not ua #6578

Merged
merged 3 commits into from
Nov 1, 2021
Merged

fix(docs)!: Ukrainian language code is uk not ua #6578

merged 3 commits into from
Nov 1, 2021

Conversation

davorpa
Copy link
Member

@davorpa davorpa commented Nov 1, 2021 •
edited

What does this PR do?

Improve repo

For resources

Description

Rename books and courses files and update targets in README.MD.

Why is this valuable (or not)?

Standardize language codes acording to ICU requirements.

See: https://www.localeplanet.com/icu/uk/index.html

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa davorpa changed the title fix!: Ukrainian language code is uk not ua fix(docs)!: Ukrainian language code is uk not ua Nov 1, 2021
@davorpa davorpa marked this pull request as ready for review November 1, 2021 03:48
@davorpa davorpa self-assigned this Nov 1, 2021
@davorpa davorpa requested a review from a team November 1, 2021 03:50
@davorpa davorpa mentioned this pull request Nov 1, 2021
Closed
39 tasks
LuigiImVector
LuigiImVector approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@LuigiImVector LuigiImVector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It respects ISO 3166-1

@LuigiImVector LuigiImVector added the 🚀 ready to merge LGTM. Waiting for final approval label Nov 1, 2021
@eshellman eshellman merged commit ef5eb6d into EbookFoundation:master Nov 1, 2021
@davorpa davorpa mentioned this pull request Sep 1, 2022
Open
14 tasks
@StepanNaryshkov
Copy link
Contributor

It respects ISO 3166-1

Sorry, but it does not respect to ISO 3166-1
image

It can be UA or UKR, but not UK, it is a big mistake

@davorpa
Copy link
Member Author

davorpa commented Oct 8, 2022 •
edited

Sorry, but it does not respect to ISO 3166-1 image

It can be UA or UKR, but not UK, it is a big mistake

Sorry but uk is the locale for ukranian, ua is the country code. There are no place to confussion

@EbookFoundation EbookFoundation locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LuigiImVector LuigiImVector LuigiImVector approved these changes

Assignees

@davorpa davorpa

Labels
🚀 ready to merge LGTM. Waiting for final approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davorpa @StepanNaryshkov @LuigiImVector @eshellman