Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(workflows): Update versions #6682

Merged
merged 1 commit into from
Feb 15, 2022
Merged

ci(workflows): Update versions #6682

merged 1 commit into from
Feb 15, 2022

Conversation

LuigiImVector
Copy link
Member

What does this PR do?

Improve repo

For resources

Description

  • Updated actions/setup-node@v1 to v2
  • Updated actions/checkout@v1 to v2
  • Updated ruby-version: 2.4.1 to 2.6

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@LuigiImVector LuigiImVector added 👀 Needs Review Is this really a good resource? Reviews requested. question Needs clarification by involved users / reviewers labels Jan 26, 2022
@davorpa
Copy link
Member

davorpa commented Jan 29, 2022 •
edited

Note: this should be automated if we activate dependabot. See my PR #5521 😉 too

@davorpa davorpa changed the title ci(workflows): Updated version ci(workflows): Update versions Jan 29, 2022
@LuigiImVector LuigiImVector requested a review from a team February 6, 2022 14:46
@davorpa davorpa added the waiting for changes PR has been reviewed and changes/suggestions requested label Feb 9, 2022
@LuigiImVector LuigiImVector mentioned this pull request Feb 14, 2022
Closed
davorpa
davorpa approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@davorpa davorpa left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for ruby version

See #6682 (comment) for clarification

@eshellman eshellman merged commit c4d9b4d into EbookFoundation:main Feb 15, 2022
@davorpa davorpa removed the waiting for changes PR has been reviewed and changes/suggestions requested label Feb 15, 2022
@davorpa davorpa added the 🔗 dependencies Address project dependencies label Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhamsing dkhamsing dkhamsing left review comments

@davorpa davorpa davorpa approved these changes

@borgified borgified Awaiting requested review from borgified

Assignees

@LuigiImVector LuigiImVector

Labels
🔗 dependencies Address project dependencies 👀 Needs Review Is this really a good resource? Reviews requested. question Needs clarification by involved users / reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LuigiImVector @davorpa @dkhamsing @eshellman