Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add courses to Arabic courses page #6937

Merged
merged 11 commits into from Jul 18, 2022
Merged

add courses to Arabic courses page #6937

merged 11 commits into from Jul 18, 2022

Conversation

Zold1
Copy link
Contributor

@Zold1 Zold1 commented Jul 18, 2022 •
edited

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@Zold1
Copy link
Contributor Author

Zold1 commented Jul 18, 2022

don't merge now, I will add more courses

@Zold1
Copy link
Contributor Author

Zold1 commented Jul 18, 2022

I'm finished

@Zold1 Zold1 changed the title add bootstrap course by Abdelrahman Gamal add courses to Arabic courses page Jul 18, 2022
@LuigiImVector
Copy link
Member

Resources are okay, but some problems with the RTL must be resolved before merging, read this #6714

@LuigiImVector LuigiImVector added waiting for changes PR has been reviewed and changes/suggestions requested 🗣️ locale:ar Resources addressing "Arabic / العربية" language labels Jul 18, 2022
LuigiImVector
LuigiImVector suggested changes Jul 18, 2022
View reviewed changes
Copy link
Member

@LuigiImVector LuigiImVector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed these two

courses/free-courses-ar.md Outdated Show resolved Hide resolved
courses/free-courses-ar.md Outdated Show resolved Hide resolved
@Zold1 Zold1 removed their assignment Jul 18, 2022
@Zold1 Zold1 requested a review from LuigiImVector July 18, 2022 18:56
@Zold1
Copy link
Contributor Author

Zold1 commented Jul 18, 2022

I removed my assignment by mistake

@LuigiImVector LuigiImVector added 🚀 ready to merge LGTM. Waiting for final approval and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Jul 18, 2022
@eshellman eshellman merged commit 2458d4b into EbookFoundation:main Jul 18, 2022
@AhmedElTabarani AhmedElTabarani mentioned this pull request Aug 5, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuigiImVector LuigiImVector LuigiImVector approved these changes

Assignees

@Zold1 Zold1

Labels
🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:ar Resources addressing "Arabic / العربية" language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zold1 @LuigiImVector @eshellman