Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the *(:card_file_box: archived)* label to all the archived entries in files "free-programming-books-subjects.md" and "free-programming-books-langs.md". #9427

Merged
merged 6 commits into from Jul 12, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 3, 2023

What does this PR do?

Add info.

For resources

Why is this valuable (or not)?

Added the (:card_file_box: archived) label to all the archived entries.

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@ghost ghost changed the title Added the "Archived" label to all the archived entries. Added the "Archived" label to all the archived entries in file "free-programming-books-subjects.md". Jul 3, 2023
@ghost ghost changed the title Added the "Archived" label to all the archived entries in file "free-programming-books-subjects.md". Added the *(:card_file_box: archived)* label to all the archived entries in file "free-programming-books-subjects.md". Jul 3, 2023
@ghost ghost changed the title Added the *(:card_file_box: archived)* label to all the archived entries in file "free-programming-books-subjects.md". Added the *(:card_file_box: archived)* label to all the archived entries in files "free-programming-books-subjects.md" and "free-programming-books-langs.md". Jul 3, 2023
@Thenlie
Copy link
Contributor

Thenlie commented Jul 4, 2023

Just curious, how did you determine these were all archived?

@ghost
Copy link
Author

ghost commented Jul 5, 2023

Just curious, how did you determine these were all archived?

The question seems a bit ambiguous to me sir.

If you mean how I found these archived listings; it was fairly simple sir!:smile: I searched for the string "archive.org", made sure it was the one either without a subdomain or with the subdomain "web", and pasted the (🗃️ archived) label wherever it was absent. I had initially written a python script to do this work, but decided to not alter the file contents programmatically lest something undesired happens.

If you mean how I got to know that these links were present on the Internet Archive; I used the Wayback Machine API for that.

@@ -545,7 +545,7 @@ Books on general-purpose programming that don't focus on a specific language are
* [The Rook's Guide to C++](http://rooksguide.org/2013/11/26/version-1-0-is-out/) - Jeremy Hansen (PDF)
* [The Ultimate Question of Programming, Refactoring, and Everything](https://www.gitbook.com/book/alexastva/the-ultimate-question-of-programming-refactoring-/details)
* [Think C++: How To Think Like a Computer Scientist](https://greenteapress.com/wp/think-c/) - Allen B. Downey (PDF)
* [Thinking in C++, Second Edition, Vol. 1.](https://archive.org/details/TICPP2ndEdVolOne) - Bruce Eckel [(Vol. 2)](https://archive.org/details/TICPP2ndEdVolTwo)
* [Thinking in C++, Second Edition, Vol. 1.](https://archive.org/details/TICPP2ndEdVolOne) - Bruce Eckel [(Vol. 2)](https://archive.org/details/TICPP2ndEdVolTwo) *(:card_file_box: archived)*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that only the web.archive.org links should be marked as "archived". IA is a legitimate place to put a book for free distribution.

Copy link
Author

@ghost ghost Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But sir, archive.org is a part of Internet Archive only.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the web.archive.org resources have been archived from the web; the others are deposited by Internet Archive users.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Okay sir. I will remove the labels.

@eshellman eshellman added the waiting for changes PR has been reviewed and changes/suggestions requested label Jul 6, 2023
@ghost ghost requested a review from eshellman July 6, 2023 13:23
@@ -470,7 +470,7 @@ Books on general-purpose programming that don't focus on a specific language are
* [The Basics of C Programming](https://www.phys.uconn.edu/~rozman/Courses/P2200_13F/downloads/TheBasicsofCProgramming-draft-20131030.pdf) - Marshall Brain (PDF)
* [The C book](http://publications.gbdirect.co.uk/c_book/) - Mike Banahan, Declan Brady, Mark Doran (PDF, HTML)
* [The C Programming Language Handbook](https://flaviocopes.com/page/c-handbook/) - Flavio Copes (PDF, EPUB, Kindle) *(email address requested)*
* [The Current C Programming Language Standard – ISO/IEC 9899:2018 (C17/C18), Draft](https://web.archive.org/web/20181230041359/http://www.open-std.org/jtc1/sc22/wg14/www/abq/c17_updated_proposed_fdis.pdf) - Open Standards Org - www.open-std.org (PDF)
* [The Current C Programming Language Standard – ISO/IEC 9899:2018 (C17/C18), Draft](https://web.archive.org/web/20181230041359/http://www.open-std.org/jtc1/sc22/wg14/www/abq/c17_updated_proposed_fdis.pdf) - Open Standards Org - www.open-std.org (PDF) *(:card_file_box: archived)*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably check if there is a version that's not draft. The change is correct, though.

@eshellman eshellman merged commit e539efc into EbookFoundation:main Jul 12, 2023
6 checks passed
@ghost ghost deleted the patch-2 branch July 13, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants