Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implication is completely broken #35

Closed
maxkratz opened this issue Sep 2, 2022 · 3 comments · Fixed by #74
Closed

Implication is completely broken #35

maxkratz opened this issue Sep 2, 2022 · 3 comments · Fixed by #74
Labels
bug Something isn't working
Projects

Comments

@maxkratz
Copy link
Member

maxkratz commented Sep 2, 2022

One of the implication tests is failing for all ILP solvers. Maybe there is a bug in the problem generation or the test case is wrong.

@maxkratz maxkratz created this issue from a note in GIPS (Bugs) Sep 2, 2022
@maxkratz maxkratz added the bug Something isn't working label Sep 7, 2022
@maxkratz maxkratz changed the title Fix failing implication test Implication is completely broken Nov 18, 2022
@maxkratz
Copy link
Member Author

Currently, the implication implementation is completely broken. In each test case, the generator does not generate any ILP constraints:

\ LP format - for model browsing. Use MPS format to capture full model detail.
Maximize
  n2n#0 + n2n#1 + n2n#2
Subject To
Bounds
Binaries
 n2n#0 n2n#1 n2n#2
End

All entries in GipsEngine.constraints do not have any ILP or depending ILP constraints.

@maxkratz
Copy link
Member Author

The implication was never completely broken; I just triggered another bug/had an error in my specification. However, with the merge of #74, the implication works just fine (after adjusting the transformation epsilon).

@maxkratz maxkratz moved this from Bugs to Done in GIPS Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
GIPS
Done
Development

Successfully merging a pull request may close this issue.

1 participant