This repository has been archived by the owner on May 9, 2022. It is now read-only.
Add Soracom as Leshan adopter. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Bernard <sbernard@sierrawireless.com>
|
I agree, I think we need to figure out a better way to let people to tests their changes. The netlify preview is not that useful since it continues to query the production API. I think we can improve testing by creating a simple HTML page that displays logos from the adopters.json file. This way the latest version will always be used when we visit the netlify preview link. |
Closed
|
I created an issue to improve testing: |
|
@sbernard31 I've tested this locally, as the process is a little more involved and can be somewhat clunky currently:
|
autumnfound
approved these changes
Dec 11, 2020
|
🙏 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add Soracom as Leshan adopters. (See eclipse-leshan/leshan#830 (comment))
I was used to do my PR to iot-eclipse.org but If I well understand, this repository must be used now ?
I tried to run
npm installthenhugo serverand the web site does display correctly.(I have no problem with iot-eclipse.org)
So I was not able to test it, I hope it's OK.