initial trial to fix the console log err + theme updates

[flora8984461]

Fix EclipseFdn/hugo-solstice-theme#193

Signed-off-by: Yi Liu yi.liu@eclipse-foundation.org

[autumnfound]

Duplicating the footer is not the answer. Duplicating HTML is almost never the answer, as it means that this site will never receive footer updates going forward. I would look at setting Site.Params.hugo_js to be assets/js/solstice.hugo.js instead (or something along those lines).

[flora8984461]

Duplicating the footer is not the answer. Duplicating HTML is almost never the answer, as it means that this site will never receive footer updates going forward. I would look at setting Site.Params.hugo_js to be assets/js/solstice.hugo.js instead (or something along those lines).

I just found that for this site, we don't really need hugo_js. 🤔 https://deploy-preview-57--eclipsefdn-adopters.netlify.app/

[chrisguindon]

@flora8984461 is this ready?

[flora8984461]

@chrisguindon I think this is ready, do you want me also add theme updating to 111 here? Or I will create a separate patch?

@autumnfound Let me know if you think more changes needed? Thanks!

[autumnfound]

Duplicating the footer is not the answer. Duplicating HTML is almost never the answer, as it means that this site will never receive footer updates going forward. I would look at setting Site.Params.hugo_js to be assets/js/solstice.hugo.js instead (or something along those lines).

I just found that for this site, we don't really need hugo_js. https://deploy-preview-57--eclipsefdn-adopters.netlify.app/

Just because we don't use it currently doesn't mean we should completely scrap the usage of the script. If we ever use it in the future for core functionality, then there would be problems on this site that are harder to identify and easily missed. We should just fix the URL rather than remove the script.

[flora8984461]

Duplicating the footer is not the answer. Duplicating HTML is almost never the answer, as it means that this site will never receive footer updates going forward. I would look at setting Site.Params.hugo_js to be assets/js/solstice.hugo.js instead (or something along those lines).

I just found that for this site, we don't really need hugo_js. https://deploy-preview-57--eclipsefdn-adopters.netlify.app/

Just because we don't use it currently doesn't mean we should completely scrap the usage of the script. If we ever use it in the future for core functionality, then there would be problems on this site that are harder to identify and easily missed. We should just fix the URL rather than remove the script.

Make sense. Updated.

[flora8984461]

Gonna wait for the new Theme and include it together here.

[autumnfound]

@flora8984461 once properly rebased, we can merge this in!

[chrisguindon]

@autumnfound Please merge if all is well! THanks!