Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example notebook to run the model with global data #93

Merged
merged 14 commits into from Feb 8, 2024

Conversation

SarahAlidoost
Copy link
Member

@SarahAlidoost SarahAlidoost commented Jan 24, 2024

closes #79
relates #EcoExtreML/STEMMUS_SCOPE#219

Broken links will be fixed after merging.

  • tested on own machine (linux)
  • tested on snellius
  • tested on CRIB --> requires python>=3.9

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@SarahAlidoost SarahAlidoost mentioned this pull request Feb 2, 2024
@SarahAlidoost SarahAlidoost marked this pull request as ready for review February 6, 2024 10:59
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly have some comments on the naming. Otherwise things look fine.

Will we want to add the (Docker) BMI way of running the model to the PyStemmusScope options? That would make the executable file and octave unnecessary (unless you want to develop the model).

mkdocs.yml Outdated Show resolved Hide resolved
SarahAlidoost and others added 4 commits February 8, 2024 11:34
Co-authored-by: Bart Schilperoort <b.schilperoort@esciencecenter.nl>
Co-authored-by: Bart Schilperoort <b.schilperoort@esciencecenter.nl>
@SarahAlidoost
Copy link
Member Author

I mostly have some comments on the naming. Otherwise things look fine.

Thanks, I fixed the text.

Will we want to add the (Docker) BMI way of running the model to the PyStemmusScope options? That would make the executable file and octave unnecessary (unless you want to develop the model).

In principle yes, but for now I would like to keep it separate for advanced users. The main users of pystemmusscope are users of CRIB who may not be familiar with docker and bmi.

@SarahAlidoost SarahAlidoost merged commit 9202ad4 into main Feb 8, 2024
14 of 15 checks passed
@SarahAlidoost SarahAlidoost deleted the add_doc_nb branch February 8, 2024 11:05
Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an example of selecting lat/lon to the netebook
2 participants