Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks indexing of
CommunityProfile
s. Previously, I had features and samples set as==
if their names were the same. I thought this was a clever way to get indexing into the underlying AxisArray with sample/feature names for free, but might be causing problems with actually constructing them.This PR removes the equality definitions, so things now have to have their underlying components
==
, and then adds methods for indexing withString
s andRegex
s. For stings, indexing is based on exact matches on the name, and for regexes, it returns allcontains(samplename, regex)
.examples: