Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump HTTP.jl to 1 and RDS to 0.5.5 #53

Merged
merged 8 commits into from
Jan 3, 2023
Merged

bump HTTP.jl to 1 and RDS to 0.5.5 #53

merged 8 commits into from
Jan 3, 2023

Conversation

rafaqz
Copy link
Member

@rafaqz rafaqz commented Dec 30, 2022

No description provided.

@visr
Copy link

visr commented Jan 3, 2023

Ha, I was just wondering why Rasters.jl holds back DataDeps to a version that needs BinaryProvider, which errors on precompilation on v1.9. This should fix that.

I see there are some X509 - Certificate verification failed, e.g. CRL, CA or signature check failed in the tests, does that need something like https://juliaweb.github.io/HTTP.jl/stable/client/#SSL-Arguments?

@rafaqz
Copy link
Member Author

rafaqz commented Jan 3, 2023

I think SRTM has just let their certs expire? Its amazing how many of these outages occur with these datasets

https://srtm.csi.cgiar.org/wp-content/uploads/files/srtm_5x5/TIFF/srtm_02_01.zip

Edit: yeah its the whole srtm:
https://srtm.csi.cgiar.org/

@rafaqz
Copy link
Member Author

rafaqz commented Jan 3, 2023

AHHHH my god and MODIS data is not permanent? How did that test work in the past and now the file is not available. SMH

Edit: could be that its deleted after 20 years. Why would they do that

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 74.20% // Head: 71.30% // Decreases project coverage by -2.89% ⚠️

Coverage data is based on head (02b327c) compared to base (502c523).
Patch coverage: 93.82% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   74.20%   71.30%   -2.90%     
==========================================
  Files          15       18       +3     
  Lines         469      711     +242     
==========================================
+ Hits          348      507     +159     
- Misses        121      204      +83     
Impacted Files Coverage Δ
src/srtm/srtm.jl 0.00% <ø> (-88.89%) ⬇️
src/types.jl 71.42% <ø> (ø)
src/modis/shared.jl 92.77% <92.77%> (ø)
src/modis/utilities.jl 93.26% <93.26%> (ø)
src/modis/products.jl 96.22% <96.22%> (ø)
src/shared.jl 64.10% <100.00%> (ø)
src/alwb/alwb.jl 0.00% <0.00%> (-81.25%) ⬇️
src/awap/awap.jl 80.00% <0.00%> (+2.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rafaqz rafaqz merged commit a28b080 into master Jan 3, 2023
@rafaqz rafaqz deleted the bump_http branch January 3, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants