Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7

Merged
merged 5 commits into from
Dec 9, 2020
Merged

Fixes #7

merged 5 commits into from
Dec 9, 2020

Conversation

rafaqz
Copy link
Member

@rafaqz rafaqz commented Dec 8, 2020

@jamesmaino for your reference, this Pr:

  1. Standardises the layer argument - it was a keyword in some places, an argument in others. Now it's always the second argument (if I got everything, there may be more inconsistencies)

  2. Fixes what is hopefully the last unix path.

@codecov-io
Copy link

codecov-io commented Dec 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c6f6253). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage          ?   74.88%           
=========================================
  Files             ?       13           
  Lines             ?      215           
  Branches          ?        0           
=========================================
  Hits              ?      161           
  Misses            ?       54           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f6253...8aed330. Read the comment docs.

download_raster(AWAP, VapourPressure{H09}; dates=dates)

@test isfile(raster_file)
if Sys.islinux()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesmaino AWAP .Z files are a pretty obscure and ancient unix format. I'm not sure if you can get the uncompress command, or work out some way to unzip them from the command line then we can add a windows specific command for it. Currently it will probably fail on windows.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right... I use 7zip. For example, this works from the command line. Would this be easy enough to add?

7z e C:\RasterData\AWAP\temperature\minave\20181231.grid.Z

@rafaqz rafaqz merged commit d16a72a into master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants