-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=========================================
Coverage ? 74.88%
=========================================
Files ? 13
Lines ? 215
Branches ? 0
=========================================
Hits ? 161
Misses ? 54
Partials ? 0 Continue to review full report at Codecov.
|
download_raster(AWAP, VapourPressure{H09}; dates=dates) | ||
|
||
@test isfile(raster_file) | ||
if Sys.islinux() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesmaino AWAP .Z files are a pretty obscure and ancient unix format. I'm not sure if you can get the uncompress
command, or work out some way to unzip them from the command line then we can add a windows specific command for it. Currently it will probably fail on windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right... I use 7zip. For example, this works from the command line. Would this be easy enough to add?
7z e C:\RasterData\AWAP\temperature\minave\20181231.grid.Z
@jamesmaino for your reference, this Pr:
Standardises the layer argument - it was a keyword in some places, an argument in others. Now it's always the second argument (if I got everything, there may be more inconsistencies)
Fixes what is hopefully the last unix path.