Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NaturalEditor: support id and class attributes on headings and paragraphs #212

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

stissot
Copy link
Member

@stissot stissot commented Oct 27, 2022

This add DOM parsing and generation capabilities as well as advanced editor buttons to edit id and class attributes on heading (<h1> to <h6>) and paragraphs (<p>) nodes.

In the editor type menu, ID and Class buttons can set the attributes on both headings and paragraphs, depending on the current selection.

For exemple one can generate:

<h1 id="chapter1" class="chapter">Chapter 1</h1>
<p id="intro1" class="intro">Welcome to a new chapter</p>

image

Copy link
Member

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PowerKiKi PowerKiKi merged commit a7f6634 into master Oct 31, 2022
@PowerKiKi PowerKiKi deleted the block-class-id branch October 31, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants