Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on how depth, surface_area and volume should be handled in NSM #83

Open
sjordan29 opened this issue Apr 23, 2024 · 1 comment
Open
Labels
nsm Specific to NSM module

Comments

@sjordan29
Copy link
Contributor

See the discussion under #78 (comment)

Need to decide how depth should be defined in NSM.

@sjordan29 sjordan29 added the nsm Specific to NSM module label Apr 23, 2024
@imscw95
Copy link
Contributor

imscw95 commented May 8, 2024

It doesn't look like surface_area and volume are direct inputs into NSM, and depth is currently just a static variable. Since the value for these 3 variables will change based on the grid cell - similar to the state variable concentrations - it makes sense to treat them like the state variables. Since NSM only needs depth as a direct function input, we can grab that directly if the hydro model keeps track of that value. However, TSM uses surface_area as a direct function input, so we will have to grab that variable for TSM anyway. But I'd think the linkage between TSM and NSM to the hydro model would be separate, since to me that linkage is all about passing the state variable dictionary back and forth, and the two modules will have different state variable dictionaries.

To me it comes down to what is easiest to track in the hydro model.

@aufdenkampe aufdenkampe added this to the NSM Initial Release milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nsm Specific to NSM module
Projects
None yet
Development

No branches or pull requests

3 participants