Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paco review #60

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Paco review #60

merged 5 commits into from
Jan 17, 2024

Conversation

Pakillo
Copy link
Member

@Pakillo Pakillo commented Jan 16, 2024

Overall package review performed

One pending task: in label.table dataset, there are a few links to fix in the QR_code column, those pointing to results from a google search (they take nowhere). Please fix, save dataset, and roxygenise again (document).

Also, the current example of herbarium labels in README generates an ugly output (at least in my computer) because one of the fields (Observations, I think) is too long, and thus the label does not fit:

image

Would be nice to shorten that field in the example dataset, or omit some other field, so that the output looks nice. Thanks

@iramosgutierrez
Copy link
Collaborator

OK Paco, thanks!
The problem with the long output for herbarium is common to Windows renderization, but somehow not to Mac (but we will modift it as you said!).
I thought the problem with the google search was already corrected, but it is clearly not, we will include it before resubmitting too!

@iramosgutierrez iramosgutierrez merged commit 21e4efb into master Jan 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants