Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: replace evaluate function with methods for call #30

Merged
merged 1 commit into from Jan 12, 2017
Merged

ENH: replace evaluate function with methods for call #30

merged 1 commit into from Jan 12, 2017

Conversation

sglyon
Copy link
Member

@sglyon sglyon commented Jan 12, 2017

This Pr replaces the evaluate function with new methods for Base.call. So now instead of evaluate(dr, args...) we do dr(args...)

@sglyon sglyon requested a review from albop January 12, 2017 18:13
@albop
Copy link
Member

albop commented Jan 12, 2017

@sglyon : Any reason to not do it ?

@sglyon
Copy link
Member Author

sglyon commented Jan 12, 2017

nope.

Performance is the same, syntax is cleaner. No hesitation from me

@albop
Copy link
Member

albop commented Jan 12, 2017

OK then. Merging now.

@albop albop closed this Jan 12, 2017
@sglyon
Copy link
Member Author

sglyon commented Jan 12, 2017

Sounds good to me, did you mean to merge or close?

@albop
Copy link
Member

albop commented Jan 12, 2017

I clicked on both... Let me try again

@albop albop reopened this Jan 12, 2017
@albop albop merged commit 2ab4959 into master Jan 12, 2017
@sglyon sglyon deleted the sl/call branch June 3, 2017 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albop albop Awaiting requested review from albop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sglyon @albop