QueryParams Builder again #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencergibb
reviewed
Oct 19, 2016
| @@ -10,6 +10,47 @@ | |||
| * @author Vasily Vasilkov (vgv@ecwid.com) | |||
| */ | |||
| public final class QueryParams implements UrlParameters { | |||
| public static final class Builder { | |||
There was a problem hiding this comment.
Consistent formatting. This project uses tabs.
There was a problem hiding this comment.
great, I will go back and adjust. Thanks for catching that.
mikekwright
force-pushed
the
master
branch
2 times, most recently
from
65600d5
to
760ad47
Compare
|
Is there anything else that would be useful to have in this PR? |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a situation while working this the consul-api where (as stated in another PR) the need for both the DataCenter and blocking information to be set was required.
Since the previous PR has not had work done on it in almost a year and noticing the significant number of files changed, we just wanted to go with a smaller PR that was targeted at just the QueryParams building aspect.
Also adjusted the QueryParams constructors to all use the newly added private total constructor.